Skip to content

python-magic Incorrectly Classifies HTML as text/plain #207 #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

python-magic Incorrectly Classifies HTML as text/plain #207 #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13ec02f
fix(views): override mime type for HTML content detection
Luis-manzur May 26, 2025
2a7ff49
chore(changelog): add entry for HTML mime type override
Luis-manzur May 26, 2025
0a69997
chore(changelog): update entry for HTML mime type override with issue…
Luis-manzur May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## Coming up
- Override mime type for HTML content detection #207

## Current

**0.3.1 - 2023-01-17**
Expand Down
4 changes: 4 additions & 0 deletions doctor/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,9 +316,13 @@ def extract_extension(request) -> HttpResponse:
r"(Audio file with ID3.*MPEG.*layer III)|(.*Audio Media.*)", file_str
):
mime = "audio/mpeg"
# If the file content contains HTML tags, override the detected mime type to text/html
elif b"<html" in content.lower() or b"<div" in content.lower():
mime = "text/html"
else:
# No workaround necessary
mime = magic.from_buffer(content, mime=True)

extension = mimetypes.guess_extension(mime)
if extension == ".obj":
# It could be a wpd, if it's not a PDF
Expand Down
Loading