DRAFT: Add DisallowShadowing rule #676
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added DisallowShadowing rule (no implementation yet). Added tests for it.
knocte
reviewed
Jan 9, 2024
knocte
reviewed
Jan 9, 2024
Implemented DisallowShadowing rule.
Added config and docs for DisallowShadowing rule.
webwarrior-ws
force-pushed
the
disallow-shadowing-squashed
branch
from
d25dadd to
f349def
Compare
|
@webwarrior-ws please add a test for shadowing for variables that start with underscore: in this case we don't want the rule to flag them. |
In DisallowShadowing rule, ignore variables that start with underscore (`_`). Added test for this case.
Added new commit with test and changes to the rule code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add DisallowShadowing rule and tests for it.
Fixes #112