-
Couldn't load subscription status.
- Fork 75
Add Sarif output support to FSharpLint.Console #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
It might also be possible to make it generate a sarif report from the |
|
Rebased on top of the latest code (The Paket changes are gone now, so previous comments about that don't apply any more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, use object initializers, please
|
Rebased to fix conflicts, haven't got to the other comments yet. |
|
Resolves #554 |
95320fc to
02456e1
Compare
02456e1 to
1a366ef
Compare
This is using the Microsoft Sarif.Sdk to write Sarif files.
| let result = | ||
| Result( | ||
| RuleId = reportDescriptor.Id, | ||
| Level = FailureLevel.Warning, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there aren't different levels for different rules, should the default here be Warning or Note?
|
Any other comments on the general idea? |
refs #554
I've recently been having a go at running some things at work through the FSharp.Analyzers.SDK analysis tools and pushing the generated Sarif report files into DevOps CI builds, and I thought it might be useful to see if I could get FSharpLint results pushed out in the same way - so, this is a first attempt at adding Sarif report generation into FSharpLint.Console.
Note: The Sarif writer code is currently a lightly modified version of the report code from https://github.com/ionide/FSharp.Analyzers.SDK just to try to get it working, so if the code style and such is wrong that's the reason.