Skip to content

Add test to agree on desired aligned behavior of ls for empty directo… #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add test to agree on desired aligned behavior of ls for empty directo… #598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions gcsfs/tests/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,14 @@ def test_ls_touch(gcs):
assert {d["name"] for d in L_d} == {a, b}


# DO NOT MERGE!
# Note: We assume this test will fail. Once it does in CI, we will update the code to make it pass.
# Only then can this PR be approved and merged.
def test_ls_empty_dir(gcs):
gcs.mkdir(TEST_BUCKET + "/test")
assert gcs.ls(TEST_BUCKET + "/test", False) == []


def test_rm(gcs):
assert not gcs.exists(a)
gcs.touch(a)
Expand Down