Skip to content

To maintain consistency, the description of the fourth component has been removed. #4092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

asp8964
Copy link

@asp8964 asp8964 commented Jul 17, 2025

  • Deleted the specific description of the fourth component mentioned in the example.
  • Ensured the text now consistently refers to and describes three components, matching the initial statement.

only three components, but example give four tips. It may be confused.
@vejol
Copy link
Contributor

vejol commented Aug 11, 2025

Thank you for the pull request. The text intentionally lists four different candidates for components to be refactored. It's good that students have to think a bit themselves about what they think should be refactored. Therefore, I won't accept this pull request.

@vejol vejol closed this Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants