feat: Creates FilterDropdown and RefineSearchPanel #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <[email protected]>
Have to finish and add the refine search dropdown for phone - maybe desktop as well.
- prepares the files for PR
❌ Deploy Preview for ucla-components-storybook failed. Why did it fail? →
|
Sveb
had a problem deploying
to
netlify-preview
GitHub Actions
Failure
There was a problem hiding this comment.
Pull Request Overview
This PR creates three new components: FilterDropdown, RefineSearchPanel, and EffectSlideToggle, along with a YearRangeFilter component. These components work together to provide a comprehensive filtering interface for search functionality.
- Creates FilterDropdown component for handling multiple filter options with checkbox selection
- Adds RefineSearchPanel as a wrapper component with collapsible functionality
- Implements EffectSlideToggle for smooth slide animations using Web Animations API
- Includes YearRangeFilter component for date range selection with dual sliders
Reviewed Changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| FilterDropdown.vue | Core filtering component with option selection and slot support |
| RefineSearchPanel.vue | Wrapper component that provides collapsible panel for filters |
| EffectSlideToggle.vue | Reusable animation component for smooth slide transitions |
| YearRangeFilter.vue | Specialized range input with dual sliders for year selection |
| _*.scss | Styling for all new components with theme support |
| *.stories.js | Storybook documentation and examples for all components |
| *.spec.js | Test specifications for component functionality |
| package.json | Updates design tokens dependency version |
| index.ts | Exports new components for library consumers |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| background-color: var(--color-white); | ||
|
|
||
| color: var(--color-secondary-grey-05); | ||
| font-weight: 500; |
There was a problem hiding this comment.
The font-weight property is declared twice on lines 31 and 34 with different values (500 and 400). This creates conflicting styles where the second declaration will override the first.
Suggested change
| font-weight: 500; |
| font-weight: 500; | ||
| font-size: 18px; | ||
| font-family: var(--font-secondary); | ||
| font-weight: 400; |
There was a problem hiding this comment.
The font-weight property is declared twice on lines 59 and 62 with different values (500 and 400). This creates conflicting styles where the second declaration will override the first.
pghorpade
had a problem deploying
to
netlify-preview
GitHub Actions
Failure
pghorpade
had a problem deploying
to
netlify-preview
GitHub Actions
Failure
pghorpade
had a problem deploying
to
netlify-preview
GitHub Actions
Failure
Sveb
had a problem deploying
to
netlify-preview
GitHub Actions
Failure
…via the arrow inputs - adjusts the spec.js file - adjusts the component and its css to make room for the min/max slider handles when they are very close next to each other,
Sveb
had a problem deploying
to
netlify-preview
GitHub Actions
Failure
- reverts the limiting feature of the filers-dropdown - updates the stoires for the also updates year-range-filter - adds the filter prefixes - renames the component and it's files..
Sveb
had a problem deploying
to
netlify-preview
GitHub Actions
Failure
Sveb
had a problem deploying
to
netlify-preview
GitHub Actions
Failure
Sveb
had a problem deploying
to
netlify-preview
GitHub Actions
Failure
Sveb
had a problem deploying
to
netlify-preview
GitHub Actions
Failure
Sveb
had a problem deploying
to
netlify-preview
GitHub Actions
Failure
Sveb
had a problem deploying
to
netlify-preview
GitHub Actions
Failure
Sveb
had a problem deploying
to
netlify-preview
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component Created: FilterDropdown.vue
Component Created: RefineSearchPanel.vue
Component Created: EffectSlideToggle.vue
Stories: ~/stories/FilterDropdown.stories.js
Stories: ~/stories/RefineSearchPanel.stories.js
Stories: ~/stories/EffectSlideToggle.stories.js
Spec: ~/stories/FilterDropdownspec.js
Spec: ~/stories/RefineSearchPanel.js
Spec: ~/stories/EffectSlideToggle.js
Notes:
Checklist:
library-website-nuxt dev server