-
Notifications
You must be signed in to change notification settings - Fork 3
feat: creates the header main funkhaus component #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR creates a new header component called HeaderMainFunkhaus for the Vue component library, providing a responsive navigation header with UCLA Digital Collections branding and hamburger menu functionality.
- Creates a new responsive header component with logo, navigation links, and mobile hamburger menu
- Implements corresponding SCSS styles for both desktop and mobile layouts
- Adds Storybook story for component documentation and testing
- Updates UCLA library design tokens to the latest version
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| HeaderMainFunkhaus.vue | Main Vue component with logo, navigation slots, and hamburger menu integration |
| GlobalHamburger.vue | Hamburger menu component for mobile navigation toggle functionality |
| _header-main-funkahaus.scss | Responsive styles for the main header component including hover states and breakpoints |
| _global-hamburger.scss | Styles for the hamburger menu icon with animation states |
| HeaderMainFunkhaus.stories.js | Storybook story demonstrating component usage with sample navigation links |
| package.json | Updates UCLA library design tokens dependency to latest version |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
packages/vue-component-library/src/styles/dlc/_header-main-funkahaus.scss:1
- The import path contains a spelling error. 'funkahaus' should be 'funkhaus' to match the correct file naming convention.
.header-main-funkahus,
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| .header-main-funkahus, | ||
| .header-main-funkahus.dlc { |
Copilot
AI
Sep 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a spelling error in the CSS class name. 'funkahus' should be 'funkhaus' to match the component name HeaderMainFunkhaus.
| .header-main-funkahus, | |
| .header-main-funkahus.dlc { | |
| .header-main-funkhaus, | |
| .header-main-funkhaus.dlc { |
|
|
||
| // Computed | ||
| const classes = computed(() => { | ||
| return ['header-main-funkahus', theme?.value || '', { 'menu-opened': props.menuOpened }] |
Copilot
AI
Sep 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CSS class name 'header-main-funkahus' has a spelling error. It should be 'header-main-funkhaus' to match the component name and avoid style application issues.
❌ Deploy Preview for ucla-components-storybook failed. Why did it fail? →
|
- refactor how the menu works, not using a slot for the menu items any longer, doesn't make sense.
Component Created: {filename}.vue
Stories: ~/stories/{filename}.stories.js
Spec: ~/stories/{filename}.spec.js
Notes:
{Any notes about what you built. How does it work? Anything missing?}
Checklist:
library-website-nuxt dev server