Skip to content

Conversation

@Sveb
Copy link

@Sveb Sveb commented Sep 24, 2025

Component Created: {filename}.vue

Stories: ~/stories/{filename}.stories.js

Spec: ~/stories/{filename}.spec.js

Notes:

{Any notes about what you built. How does it work? Anything missing?}

Checklist:

  • I checked that it is working locally in the dev server
  • I checked that it is working locally in the storybook
  • I checked that it is working locally in the
    library-website-nuxt dev server
  • I added a screenshot of it working
  • UX has reviewed and approved this
  • I assigned this PR to someone on the dev team to review
  • I used a conventional commit message
  • I assigned myself to this PR

@Sveb Sveb changed the title feat: crrates the header main funkhaus component feat: creates the header main funkhaus component Sep 24, 2025
@Sveb Sveb requested a review from Copilot September 24, 2025 13:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR creates a new header component called HeaderMainFunkhaus for the Vue component library, providing a responsive navigation header with UCLA Digital Collections branding and hamburger menu functionality.

  • Creates a new responsive header component with logo, navigation links, and mobile hamburger menu
  • Implements corresponding SCSS styles for both desktop and mobile layouts
  • Adds Storybook story for component documentation and testing
  • Updates UCLA library design tokens to the latest version

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
HeaderMainFunkhaus.vue Main Vue component with logo, navigation slots, and hamburger menu integration
GlobalHamburger.vue Hamburger menu component for mobile navigation toggle functionality
_header-main-funkahaus.scss Responsive styles for the main header component including hover states and breakpoints
_global-hamburger.scss Styles for the hamburger menu icon with animation states
HeaderMainFunkhaus.stories.js Storybook story demonstrating component usage with sample navigation links
package.json Updates UCLA library design tokens dependency to latest version
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)

packages/vue-component-library/src/styles/dlc/_header-main-funkahaus.scss:1

  • The import path contains a spelling error. 'funkahaus' should be 'funkhaus' to match the correct file naming convention.
.header-main-funkahus,

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +1 to +2
.header-main-funkahus,
.header-main-funkahus.dlc {
Copy link

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a spelling error in the CSS class name. 'funkahus' should be 'funkhaus' to match the component name HeaderMainFunkhaus.

Suggested change
.header-main-funkahus,
.header-main-funkahus.dlc {
.header-main-funkhaus,
.header-main-funkhaus.dlc {

Copilot uses AI. Check for mistakes.

// Computed
const classes = computed(() => {
return ['header-main-funkahus', theme?.value || '', { 'menu-opened': props.menuOpened }]
Copy link

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS class name 'header-main-funkahus' has a spelling error. It should be 'header-main-funkhaus' to match the component name and avoid style application issues.

Copilot uses AI. Check for mistakes.
@netlify
Copy link

netlify bot commented Sep 24, 2025

Deploy Preview for ucla-components-storybook failed. Why did it fail? →

Name Link
🔨 Latest commit d4be143
🔍 Latest deploy log https://app.netlify.com/projects/ucla-components-storybook/deploys/68f7b84a55c2220008cbe683

- refactor how the menu works, not using a slot for the menu items any longer, doesn't make sense.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant