Skip to content

Conversation

@figuerom16
Copy link
Contributor

@figuerom16 figuerom16 commented Jun 30, 2025

This seems to fix issues with resizing causing lag and text to loop and haven't been able to generate an out of bounds issue with Fyne.Do being added.

@figuerom16
Copy link
Contributor Author

figuerom16 commented Jun 30, 2025

This seems to fix the same issue as #121. Not sure if one or the other is the better fix or if both are needed.

@figuerom16 figuerom16 requested a review from andydotxyz July 1, 2025 00:39
@nagylzs
Copy link

nagylzs commented Jul 1, 2025

Please correct me if I'm wrong, but AFAIK, all BaseWidget (and CanvasObject) methods must be called from the main fyne thread. TextGrid implements BaseWidget, so TextGrid.Refresh must be called from the main fyne thread.

This commit:

30e28c2

hides the problem when TextGrid.Refresh is not called from the main fyne thread; but it does not fix it. The real fix would be to find out which code calls TextGrid.Refresh directly from another thread.

Please forgive me if I write something stupid, I'm new to this.

@figuerom16
Copy link
Contributor Author

I see. It's the opposite of what I was thinking then.

@figuerom16 figuerom16 closed this Jul 1, 2025
@andydotxyz
Copy link
Member

This commit: 30e28c2 hides the problem when TextGrid.Refresh is not called from the main fyne thread; but it does not fix it. The real fix would be to find out which code calls TextGrid.Refresh directly from another thread.

Correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants