- 
                Notifications
    You must be signed in to change notification settings 
- Fork 144
Add dartboards #500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            marklescroart
  wants to merge
  15
  commits into
  gallantlab:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
piecesofmindlab:add_dartboards
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            Add dartboards #500
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | It looks like the code reverted back to using sklearn? | 
| Yeah this is still WIP.On Nov 15, 2023, at 12:24 PM, Matteo Visconti di Oleggio Castello ***@***.***> wrote:
It looks like the code reverted back to using sklearn?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***> | 
| @marklescroart the failing tests have been fixed by #536. please rebase or merge master so we can make sure everything passes. | 
…al dartboard functions and argument-passing
… over flatmap, this needs update
… exposing of other functions, but almost ready.
Adding cutoff param to select n_vertices or % vertices below which to set dartboard bin to nan. Functionality already exists in apply_masks function. Just added the param to get_dartboard_data.
8c28079    to
    506993a      
    Compare
  
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Adds code to create "dartboard" visualizations of brain activity, i.e. radial grid bin resampling of space around a defined centroid, warped according to defined anchor points.