[gaml] raises a warning when arbitrary operator resolution has been done on an ambiguous call - #1179
Draft
lesquoyb wants to merge 1 commit into
Draft
[gaml] raises a warning when arbitrary operator resolution has been done on an ambiguous call#1179lesquoyb wants to merge 1 commit into
lesquoyb wants to merge 1 commit into
Conversation
…one on an ambiguous call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves #1176 by informing the modeler with a warning.
I think we can use that to first fix our own models in the library that "benefit" from this ambiguity. Actually for some operators it doesn't make a difference because one definition just redirect to the other after a cast. But it's probably a very bad practice to use "random" operators in our code base.
Maybe once it's done we could turn that warning into a real compile time error?