-
-
Notifications
You must be signed in to change notification settings - Fork 127
Update ios.mdx #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update ios.mdx #518
Conversation
WalkthroughThe documentation for iOS deployment was updated to change a permission-fixing command from targeting a single file name (usymtool) to a glob pattern (usymtool*), affecting how files are matched during the "Fix File Permissions and Run fastlane" step. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant CI as CI Workflow
participant Runner as Build Runner
participant Env as iOS Build Env
Dev->>CI: Push changes / trigger iOS deploy
CI->>Runner: Run "Fix File Permissions and Run fastlane"
note over Runner: Changed: apply execute bit to files matching "usymtool*"
Runner->>Env: chmod +x .../usymtool*
Runner->>Env: fastlane ios release
Env-->>Runner: Build and upload artifacts
Runner-->>CI: Step complete
CI-->>Dev: Deployment result
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Visit the preview URL for this PR (updated for commit 7f3f69c): https://game-ci-5559f--pr518-davidmfinol-patch-5-lpn0lsra.web.app (expires Mon, 06 Oct 2025 15:54:59 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1f0574f15f83e11bfc148eae8646486a6d0e078b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/03-github/06-deployment/ios.mdx (1)
488-488
: Broadened match looks good; tighten robustness (quote path, batch -exec).Using
-iname "usymtool*"
is a sensible expansion to catch variant filenames. To harden this step:
- Quote the path to survive spaces.
- Use
-exec … +
to batch chmod calls.- Optionally align the prior
.sh
line for consistency.Apply this minimal change to the modified line:
-find $IOS_BUILD_PATH -type f -iname "usymtool*" -exec chmod +x {} \; +find "$IOS_BUILD_PATH" -type f -iname 'usymtool*' -exec chmod +x {} +For consistency with the previous line (outside this hunk), consider:
find "$IOS_BUILD_PATH" -type f -name '*.sh' -exec chmod +x {} + find "$IOS_BUILD_PATH" -type f -iname 'usymtool*' -exec chmod +x {} +
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/03-github/06-deployment/ios.mdx
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build_and_preview
Summary by CodeRabbit