Fix fuzzy_compare to properly work with arrays. #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually this is a rewrite of fuzzy_compare which primarily make it work with arrays. Current implementation was not correct with more than one element in the array. What is more, I believe that when comparing kubernetes descriptors we should compare arrays by their content *ignoring element order*. That's because kubernetes will reorder elements in arrays (I can't think of a case where element order is significant) after initial descriptor upload. Based on garethr/garethr-kubernetes@accf0b5
|
I see at least one instance where array order is important: container command arguments. But we can possibly live with this drawback. But, more important, your version seems incorrect to me. |
This was referenced Feb 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually this is a rewrite of fuzzy_compare which primarily make it
work with arrays.
Current implementation was not correct with more than one element in the
array. What is more, I believe that when comparing kubernetes
descriptors we should compare arrays by their content ignoring element
order. That's because kubernetes will reorder elements in arrays (I
can't think of a case where element order is significant) after initial
descriptor upload.
This is 1:1 based on commit you already cherry-picked in gareth-kubernetes from my fork:
garethr/garethr-kubernetes@accf0b5