Line3: increase test coverage (backport #813) - #835
Open
mergify[bot] wants to merge 2 commits into
Open
Conversation
* Line3: increase test coverage 1. Default Constructor: Tested Line3() initialization. 2. Added tests for Set(const Vector3<T>&, const Vector3<T>&). 3. Intersect Edge Cases: parallel non-overlapping line segments, parallel overlapping segments, and non-intersecting skew lines. 4. Template Types: Added test cases for Line3i (int) and Line3f (float). Assisted-by: Gemini 3.6 Flash Signed-off-by: Steve Peters <scpeters@intrinsic.ai> * Line3: fix conversion warnings with static_cast<T> Assisted-by: Gemini 3.6 Flash Signed-off-by: Steve Peters <scpeters@intrinsic.ai> --------- Signed-off-by: Steve Peters <scpeters@intrinsic.ai> (cherry picked from commit 578203f) # Conflicts: # src/python_pybind11/test/Line3_TEST.py
Contributor
Author
|
Cherry-pick of 578203f has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
19 tasks
ahcorde
approved these changes
Aug 26, 2026
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
ahcorde
enabled auto-merge (squash)
August 26, 2026 11:22
scpeters
disabled auto-merge
August 26, 2026 11:38
Member
|
I'd like to generate backports from #821 since it has the fixed commit attribution and doesn't need the DCO bot warning to be manually ignored |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Improve test coverage of the
Line3class, similar to #807Summary
This increases test coverage based on suggestions from Gemini and uses
static_cast<T>where needed to fix windows C4244 compiler warnings.Summary of test coverage improvements
Line3()initialization.Set(const Vector3<T>&, const Vector3<T>&).Line3i(int) andLine3f(float).Backport Policy
Checklist
codecheckpassed (See contributing)Assisted-by: Gemini 3.6 Flash
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.Backports: If this is a backport, please use Rebase and Merge instead.
This is an automatic backport of pull request #813 done by [Mergify](https://mergify.com).