Fix mergeSort bug #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mergesort is now mergeSort, to follow Kotlin naming conventions.
items is now of type List instead of MutableList, because the subList method is only available on List.
items.count() is now items.size.
The base case in mergeSort is now if (items.size <= 1) instead of if (items.isEmpty()), because isEmpty() won't work for a non-mutable list.
The temp variable in merge is now initialized to the first element of left or right, instead of being declared without a value.
The leftIndex and rightIndex variables are now used to keep track of the current index in left and right, respectively.
The addAll method is now called on merged, not on the list being added.
The var keyword is changed to val wherever possible, to avoid unnecessary mutability.
The main function is unchanged, but I removed the var keyword when declaring ordered, since it doesn't need to be mutable.