-
Notifications
You must be signed in to change notification settings - Fork 7
[ENH] making AptaTrans sklearn-like and notebook for Benchmarking
#165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…on tests and bug fixing
BenchmarkingAptaTrans sklearn-like and notebook for Benchmarking
|
@NennoMP for whenever you have time, given I think I have done most of what I could do:
|
I'll give it a look this week. Where is bug (2.) occurring specifically, an you provide the traceback? The AptaTrans notebook is working on my side, so the problem could be in the benchmark class and/or benchmark notebook. |
I do not think I implemented AptaTrans correctly😅 It is failing before benchmarking in this cell in the benchmarking notebook: with this error: |
This method was intended as a quick, easy way to evaluate a pair
I just ran this and you are right. The issue is in setting the tree search depth of This isn't really a issue though. I think you would never want aptamer candidate of length as short as 1 or 2. By the way, the branch is a few commits behind main. |
|
Oh I thought you could take over on this is what I implied last meeting 😅 The points I made were the points for you to address/things still left to do. If you cannot pick this up let me know and I will try and have a look at it, felt it would be way easier of a task for you than me hence the suggestion. Edit: @NennoMP I just realised we are yet to make AptaTrans regression-friendly! (maybe part of another PR though) |
Stacks on #114
closes #164 and closes #190
Adds a tutorial notebook for benchmarking.