Skip to content

Conversation

@fkiraly
Copy link
Contributor

@fkiraly fkiraly commented Nov 1, 2025

improves aptacom loader docstrings - actions the comments by @satvshr that I overlooked in #158.

Sorry for missing these and merging.

@fkiraly fkiraly added the documentation Improvements or additions to documentation label Nov 1, 2025
@satvshr
Copy link
Collaborator

satvshr commented Nov 1, 2025

Missing it was fine and totally understandable, thanks for making an issue and trying to fix the change requests! Could you tell me why these changes should not be made for future purposes:

  1. Link
  2. Link

@satvshr
Copy link
Collaborator

satvshr commented Nov 13, 2025

New files introduced? Apart from that, LGTM!

@rpgv rpgv force-pushed the aptacom-docstrings branch from 6c83192 to fa942f7 Compare November 18, 2025 19:13
@fkiraly
Copy link
Contributor Author

fkiraly commented Nov 25, 2025

Missing it was fine and totally understandable, thanks for making an issue and trying to fix the change requests! Could you tell me why these changes should not be made for future purposes:

should we not name all functions with x and y in their name similarly? So this would be prepare_x_y instead.

I think it does not matter since it is not intended to be a public function (and should perhaps start with a _ hence)

Should this function not be private? Also do you mind changing ds to df (for dataframe) given ds is something I will be using for the Dataset object from HuggingFace?

Actually, yes.

@satvshr
Copy link
Collaborator

satvshr commented Nov 25, 2025

Seems like everything I brought up has been resolved, can be merged now!

@fkiraly fkiraly merged commit 2a12eb7 into main Nov 27, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants