Skip to content

Conversation

0xh3rman
Copy link
Collaborator

@0xh3rman 0xh3rman commented Oct 7, 2025

No description provided.

Copy link

semanticdiff-com bot commented Oct 7, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  gemstone/src/models/transaction.rs  91% smaller
  crates/gem_evm/src/everstake/contracts.rs  14% smaller
  crates/gem_evm/src/provider/staking_ethereum.rs  14% smaller
  apps/parser/src/consumers/fetch_token_addresses_consumer.rs  12% smaller
  crates/gem_evm/src/everstake/mapper.rs  1% smaller
  crates/gem_evm/src/everstake/state.rs  0% smaller

Copy link
Contributor

Summary of Changes

Hello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive support for tracking and displaying restaked rewards within the Everstake Ethereum staking integration. It updates the underlying smart contract interface definition, enhances internal data models to store reward information, and refactors the staking balance calculation logic to accurately reflect these rewards alongside staked and pending balances, providing users with a more transparent view of their staking performance.

Highlights

  • Everstake Rewards Integration: The system now fetches and displays restaked rewards for Everstake staking accounts on the Ethereum network, providing a more complete view of user holdings.
  • Data Structure Enhancement: Internal data structures, specifically EverstakeAccountState and DelegationBase, have been updated to include a dedicated restaked_reward field to store and track reward information.
  • Smart Contract Interface Update: The IAccounting smart contract interface definition was extended with a restakedRewardOf function, and the get_everstake_account_state function now utilizes this to retrieve the reward data via a multicall.
  • Staking Balance Calculation Refinement: The logic for calculating Ethereum staking balances within get_ethereum_staking_balance has been revised to correctly aggregate and present staked balances, pending balances, and the newly integrated rewards.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully adds support for rewards in Everstake staking. The changes are logical and well-implemented across the different crates. I've identified a couple of areas where maintainability can be improved. Please see my detailed comments below.

@0xh3rman 0xh3rman merged commit f8c6352 into main Oct 7, 2025
5 checks passed
@0xh3rman 0xh3rman deleted the everstake-rewards branch October 7, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant