-
Notifications
You must be signed in to change notification settings - Fork 53
Add Swap Status for cross chain swap tx view #1279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This PR introduces comprehensive support for displaying cross-chain swap transaction statuses and details within the transaction view. It integrates a new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This is a good pull request that adds a much-needed feature for cross-chain swaps. The implementation of status polling with exponential backoff is solid. I've added a few suggestions to improve code clarity and maintainability. Keep up the great work!
Features/Transactions/Sources/ViewModels/TransactionSceneViewModel.swift
Show resolved
Hide resolved
Features/Transactions/Sources/ViewModels/TransactionStatusViewModel.swift
Outdated
Show resolved
Hide resolved
Features/Transactions/Sources/ViewModels/TransactionSwapHashViewModel.swift
Outdated
Show resolved
Hide resolved
For Near Intents, we need to query by deposit address not tx hash, need to update SwapTransactionService to have local tx data (destination and memo etc) |
Fixes #381
