Skip to content

Conversation

0xh3rman
Copy link
Contributor

@0xh3rman 0xh3rman commented Oct 8, 2025

Fixes #381
Simulator Screenshot - iPhone 17 Pro - 2025-10-08 at 20 40 54

Copy link
Contributor

Summary of Changes

Hello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This PR introduces comprehensive support for displaying cross-chain swap transaction statuses and details within the transaction view. It integrates a new SwapTransactionService to fetch real-time swap results, enhances the UI with dedicated status and transaction hash fields, and includes necessary infrastructure and localization updates.

Highlights

  • Intent: This pull request aims to enhance the transaction details view by adding specific status and transaction hash information for cross-chain swap transactions. This allows users to quickly understand the state and details of their swaps, including source and destination transaction IDs.
  • Changes Summary: The PR introduces a new SwapResult type in Primitives to represent the status and details of a swap. A new SwapTransactionService is added to FeatureServices/SwapService to fetch these swap results from the GemSwapper library, including logic to map SwapperSwapResult to the new Primitives.SwapResult. The Transactions feature is updated to consume this new service. Specifically, TransactionSceneViewModel now takes a SwapResultProviding dependency, fetches SwapResult for cross-chain swaps using a polling mechanism with exponential backoff, and conditionally displays new UI elements. New TransactionItem cases (swapStatus, sourceTransaction, destinationTransaction) are introduced, along with a new TransactionSwapHashViewModel to render the source and destination transaction hashes. The existing TransactionStatusViewModel is extended to display swap-specific statuses (e.g., 'Refunded') when a SwapResult is available. Dependency injection for SwapTransactionService is set up across the application's navigation stacks (TransactionsNavigationStack, WalletNavigationStack), AppResolver, ServicesFactory, and Environment. Localization strings for the new UI elements are also added. A new test case verifies the correct display of swap status and destination transaction details.
  • Reviewer Activity Summary: No specific reviewer activity was provided in the context.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This is a good pull request that adds a much-needed feature for cross-chain swaps. The implementation of status polling with exponential backoff is solid. I've added a few suggestions to improve code clarity and maintainability. Keep up the great work!

@0xh3rman 0xh3rman marked this pull request as draft October 9, 2025 21:53
@0xh3rman
Copy link
Contributor Author

0xh3rman commented Oct 9, 2025

For Near Intents, we need to query by deposit address not tx hash, need to update SwapTransactionService to have local tx data (destination and memo etc)

@0xh3rman 0xh3rman marked this pull request as ready for review October 11, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Swap Transaction Status

1 participant