Reserve fee info text for Max button #1302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces StakeMinimumValueValidator to validate stake amounts while ensuring users have sufficient balance to cover both the stake and network fee reserves. Key changes: - Add StakeMinimumValueValidator checking available balance >= value + reservedForFee - Add TransferError.insufficientStakeBalance with detailed breakdown - Integrate validator into AmountSceneViewModel for .stake and .freeze operations - Tron staking excluded (no fee reservation required) - Comprehensive test coverage for validator and integration This prevents users from staking amounts that would leave insufficient balance for transaction fees, improving user experience with clear error messages.
…take-minimum-validator-with-fee-reservation # Conflicts: # core
…take-minimum-validator-with-fee-reservation
Remove StakeMinimumValueValidator in favor of automatic fee reservation in maxBalance calculation. Fee handling now integrated directly into balance computation, showing info text only when entering exact maximum amount.
…take-minimum-validator-with-fee-reservation # Conflicts: # core
…take-minimum-validator-with-fee-reservation # Conflicts: # core
Reworded the 'transfer.reserved_fees' string in all supported languages to clarify that the reserved amount covers future network fees, not just withdrawal fees. Updated the Transaction model to make 'blockNumber' and 'sequence' non-optional, and removed the 'transaction' property from PushNotificationTransaction for simplification.
Revised the 'transfer.reserved_fees' string in Localized.swift and all supported language files for improved clarity and consistency. The message now consistently states that the amount is left in the balance to cover future network fees, rather than being left out or excluded.
Updated the Transaction struct to allow blockNumber and sequence to be optional, reflecting cases where these values may not be present. Also updated PushNotificationTransaction to include a Transaction instance, ensuring richer notification payloads.
gemcoder21
deleted the
feature/stake-minimum-validator-with-fee-reservation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Show reserved fees info text only when user taps Max button for stake/freeze operations.
Changes
StakeMinimumValueValidator- fee reservation now integrated intomaxBalancecalculationshouldReserveFeeandreserveForFeeas computed propertiesavailableBalanceForStaking→availableBalanceForMaxStakingTODO