Skip to content

add explicit react native check #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025
Merged

Conversation

erquhart
Copy link
Collaborator

@erquhart erquhart commented May 16, 2025

Despite being deprecated and defined in specs as "returning 'Gecko' in all browsers", going with checking navigator.product.

  • It's the only explicit way to check for the RN/Expo environment
  • The React Native devs have kept this defined consistently since at least 2018 (source)
  • Expo co-founder James Ide backed it (source)
  • Axios uses it (source)

There's no right way to do this, but I really don't want devs to have to go set a prop for this thing that no one should need to think about.

Fixes #206
Fixes #214

Replaces #216

Copy link

vercel bot commented May 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
convex-auth-docs ✅ Ready (Inspect) Visit Preview May 16, 2025 11:11pm

@erquhart erquhart requested a review from thomasballinger May 16, 2025 23:11
@erquhart erquhart merged commit f7b16ab into main May 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not working on expo app for ios or android NotSupportedError: Cannot set "location.href"
3 participants