Skip to content

Conversation

dividedmind
Copy link
Contributor

This pull request introduces a new feature to download and manage content exclusions from GitHub. The key changes include adding new utility functions for handling exclusions, modifying the chat completion service to ensure exclusions are downloaded, and adding tests for the new functionality.

vscode-gh-exclusion.mp4

New functionality for handling exclusions:

  • src/lib/exclusionUtils.ts: Added functions to download content exclusions (downloadContentExclusions), ensure exclusions are downloaded (ensureExclusionsDownloaded), and attempt to download exclusions (tryDownloadingExclusions). Also added functions to get GitHub tokens and handle errors during exclusion downloads.

  • src/lib/fetchGHExclusions.ts: Added a new module to fetch content exclusions from GitHub, including the fetchGHExclusions function and related types (GitHubContentExclusion, Rule, Scope).

Modifications to chat completion service:

Tests for new functionality:

  • test/unit/lib/fetchGHExclusions.test.ts: Added unit tests for the fetchGHExclusions function to verify successful fetching, handling of 404 responses, and error handling for other response statuses.

Dependency updates:

  • package.json: Removed the @appland/appmap dependency and cleaned up the resolutions section. [1] [2]

@dividedmind dividedmind self-assigned this Feb 9, 2025
It's currently unused and brings a lot of stuff in.
@dividedmind dividedmind force-pushed the feat/download-content-exclusion branch 3 times, most recently from 27d2d98 to b4e12dd Compare February 11, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant