Skip to content

Conversation

@nicholasxuu
Copy link

No description provided.

@notmedia
Copy link
Contributor

notmedia commented Jun 8, 2023

Hi, thank you for opening this PR! I have some points we need to discuss:

  1. Could you elaborate about your case and infrastructure, why you need this option? I want to reproduce it and make some tests.
  2. If the grpc.default_authority is set you are also setting the same value to the grpc.ssl_target_name_override option. I think this can break some scenarios where the values might be different. But need investigate this, for example - Negotiating TLS when using authority for Envoy routing grpc/grpc-node#655
  3. I moved grpc-client from this project to separate library - https://github.com/getezy/grpc-client where I will add this option too after investigating.

@notmedia notmedia self-requested a review June 8, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants