Skip to content

Conversation

atavism
Copy link
Contributor

@atavism atavism commented Sep 30, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings September 30, 2025 16:58
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR decouples the IPC server lifecycle from the tunnel lifecycle by introducing a new start endpoint and moving IPC initialization to a separate function. The IPC server now runs independently and can start/stop tunnel services on demand.

  • Removed IPC server initialization from tunnel establishment
  • Added new start endpoint to the IPC server for on-demand tunnel creation
  • Introduced InitIPC function to manage long-lived IPC server lifecycle

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
vpn/tunnel.go Removed IPC server initialization and cleanup from tunnel establishment
vpn/ipc/server.go Added start endpoint handler and StartFn callback mechanism
vpn/ipc/endpoints.go Added new start service endpoint constant
vpn/ipc.go New file containing InitIPC function and tunnel startup logic

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@atavism atavism requested a review from Copilot September 30, 2025 19:51
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@atavism
Copy link
Contributor Author

atavism commented Oct 2, 2025

@garmr-ulfr @WendelHime I'm testing these changes today on Windows but feel free to take a look!

Copy link
Collaborator

@garmr-ulfr garmr-ulfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atavism
Copy link
Contributor Author

atavism commented Oct 7, 2025

Thanks for the review, @garmr-ulfr!

@atavism atavism merged commit 8c3e34a into main Oct 7, 2025
2 checks passed
@atavism atavism deleted the atavism/radiance-ipc-start branch October 7, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants