feat(init): accept multiple delimiter formats for --features flag#386
Merged
feat(init): accept multiple delimiter formats for --features flag#386
Conversation
Allow comma, plus, and space as delimiters, support repeated --features flags (variadic), and add --feature as a singular alias. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Init
Other
Bug Fixes 🐛Init
Other
Internal Changes 🔧Init
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 104 passed | Total: 104 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 899 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 95.48% 95.48% —%
==========================================
Files 142 142 —
Lines 19898 19901 +3
Branches 0 0 —
==========================================
+ Hits 18999 19002 +3
- Misses 899 899 —
- Partials 0 0 —Generated by Codecov Action |
Stricli aliases must be single characters. The `feature: "features"` alias would be interpreted as batched single-char flags `-f -e -a -t -u -r -e`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Apply PR suggestion: "You can visit" instead of "Visit" for a friendlier tone. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
--featuresmore flexible per @BYK's review feedback. Now accepts:--features errors,tracing,logs--features errors+tracing+logs--features "errors tracing logs"--features errors --features tracing--features errors,tracing --features logsThe flag is now variadic (collects multiple values into an array) with a regex split on
,,+, and space delimiters.Changes
stringtostring[]withvariadic: trueflatMap+ regex split across all entriesTest plan
bun run typecheckpassesbun run lintpassesbun test test/commands/init.test.ts— 10/10 pass🤖 Generated with Claude Code