Skip to content

chore(features): cleanup feature flags grouped by its' category #3843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025

Conversation

aldy505
Copy link
Collaborator

@aldy505 aldy505 commented Aug 1, 2025

As a follow up for #3837 (comment)

@aldy505
Copy link
Collaborator Author

aldy505 commented Aug 1, 2025

@evanpurkhiser I removed the feature flags for uptime issue platform & sentry option for write uptime results to snuba. Hoping you can review & approve if I'm correct.

Copy link

codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.45%. Comparing base (84d0d23) to head (b04327d).
⚠️ Report is 3 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3843   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files           3        3           
  Lines         183      183           
=======================================
  Hits          182      182           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evanpurkhiser
Copy link
Member

Yep it's safe to remove the uptime flags

@evanpurkhiser
Copy link
Member

Will leave it to someone else to approve.

@aldy505 aldy505 merged commit d576137 into master Aug 6, 2025
13 checks passed
@aldy505 aldy505 deleted the aldy505/chore/feature-categorization-cleanup branch August 6, 2025 00:05
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants