-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
SDK search bar focus bug on Javascript and browser javascript #14870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
SDK search bar focus bug on Javascript and browser javascript #14870
Conversation
Cursor Agent can help with this pull request. Just |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bundle ReportChanges will increase total bundle size by 883 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
Files in
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
Files in
|
Co-authored-by: shannon.anahata <[email protected]>
Co-authored-by: shannon.anahata <[email protected]>
Co-authored-by: shannon.anahata <[email protected]>
Co-authored-by: shannon.anahata <[email protected]>
Co-authored-by: shannon.anahata <[email protected]>
…dling Co-authored-by: shannon.anahata <[email protected]>
Co-authored-by: shannon.anahata <[email protected]>
Co-authored-by: shannon.anahata <[email protected]>
Co-authored-by: shannon.anahata <[email protected]>
Co-authored-by: shannon.anahata <[email protected]>
Co-authored-by: shannon.anahata <[email protected]>
DESCRIBE YOUR PR
This PR resolves an issue where the platform search bar in the left navigation would lose focus on the JavaScript platform, specifically when "Browser JavaScript" was selected.
The root cause was a key collision: the "Browser JavaScript" platform's
platformTitle
configuration caused a virtual guide to be created with the same key (javascript
) as the platform itself. This collision triggered special handling in thePlatformSelector
component that led to the focus loss.The fix modifies
src/docTree.ts
to append-platform
to the virtual guide's key (e.g.,javascript-platform
), preventing the collision and restoring normal focus behavior for the search bar.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES
Slack Thread