Skip to content

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Nov 20, 2025

DESCRIBE YOUR PR

The motivation behind this PR is to change "This is important" to "This is required" in the cocoapods instructions. However I also noticed that we recommended using cocoapods, even though cocoapods as a whole is in maintenance mode and not recommended for iOS apps so I updated it to recommend SPM.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Nov 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Nov 20, 2025 8:08pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Nov 20, 2025 8:08pm

@codeowner-assignment codeowner-assignment bot requested a review from a team November 20, 2025 17:50
.package(url: "https://github.com/getsentry/sentry-cocoa", from: "{{@inject packages.version('sentry.cocoa') }}"),
```

<Alert>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seemed to do more harm than good since it's been years since it was relevant and distracts from the important parts of the docs

@codecov
Copy link

codecov bot commented Nov 20, 2025

Bundle Report

Changes will increase total bundle size by 10.16kB (0.04%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 12.99MB 10.17kB (0.08%) ⬆️
sentry-docs-client-array-push 10.18MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
server/middleware-*.js -6.46kB 1.0kB -86.59%
server/middleware-*.js 6.46kB 7.46kB 645.5% ⚠️
static/KCqJPeM8XShsowBjLKa7p/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/KCqJPeM8XShsowBjLKa7p/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/vme93T5iydrHwr4wMjom5/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/vme93T5iydrHwr4wMjom5/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.74MB -0.0%
../instrumentation.js -3 bytes 1.07MB -0.0%
9523.js -3 bytes 1.04MB -0.0%
../app/[[...path]]/page.js.nft.json 3.39kB 889.34kB 0.38%
../app/platform-redirect/page.js.nft.json 3.39kB 889.26kB 0.38%
../app/sitemap.xml/route.js.nft.json 3.39kB 886.49kB 0.38%

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM, we should add more migration information

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my side the doc changes look good since the reflect the current state of things 👍

We can iterate on the way forward for the RN SDK separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants