-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update cocoa SDK setup instructions #15587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
| .package(url: "https://github.com/getsentry/sentry-cocoa", from: "{{@inject packages.version('sentry.cocoa') }}"), | ||
| ``` | ||
|
|
||
| <Alert> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seemed to do more harm than good since it's been years since it was relevant and distracts from the important parts of the docs
Bundle ReportChanges will increase total bundle size by 10.16kB (0.04%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
c023fe2 to
1502920
Compare
philprime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM, we should add more migration information
antonis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On my side the doc changes look good since the reflect the current state of things 👍
We can iterate on the way forward for the RN SDK separately.
DESCRIBE YOUR PR
The motivation behind this PR is to change "This is important" to "This is required" in the cocoapods instructions. However I also noticed that we recommended using cocoapods, even though cocoapods as a whole is in maintenance mode and not recommended for iOS apps so I updated it to recommend SPM.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: