Skip to content

Commit b589acb

Browse files
committed
Fix tests for Spring 7 and Spring Boot 4
1 parent 8d5bfcf commit b589acb

File tree

5 files changed

+12
-11
lines changed

5 files changed

+12
-11
lines changed

sentry-spring-7/src/main/java/io/sentry/spring/jakarta/SentryHubRegistrar.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public class SentryHubRegistrar implements ImportBeanDefinitionRegistrar {
2323

2424
static {
2525
SentryIntegrationPackageStorage.getInstance()
26-
.addPackage("maven:io.sentry:sentry-spring-jakarta", BuildConfig.VERSION_NAME);
26+
.addPackage("maven:io.sentry:sentry-spring-7", BuildConfig.VERSION_NAME);
2727
}
2828

2929
@Override
@@ -99,6 +99,6 @@ private void registerSentryExceptionResolver(
9999
}
100100

101101
private static void addPackageAndIntegrationInfo() {
102-
SentryIntegrationPackageStorage.getInstance().addIntegration("Spring6");
102+
SentryIntegrationPackageStorage.getInstance().addIntegration("Spring7");
103103
}
104104
}

sentry-spring-7/src/test/kotlin/io/sentry/spring/jakarta/EnableSentryTest.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,13 @@ class EnableSentryTest {
4747
contextRunner.run {
4848
assertThat(it).hasSingleBean(SentryOptions::class.java)
4949
val options = it.getBean(SentryOptions::class.java)
50-
assertThat(options.sentryClientName).isEqualTo("sentry.java.spring.jakarta")
50+
assertThat(options.sentryClientName).isEqualTo("sentry.java.spring-7")
5151
assertThat(options.sdkVersion).isNotNull
52-
assertThat(options.sdkVersion!!.name).isEqualTo("sentry.java.spring.jakarta")
52+
assertThat(options.sdkVersion!!.name).isEqualTo("sentry.java.spring-7")
5353
assertThat(options.sdkVersion!!.version).isEqualTo(BuildConfig.VERSION_NAME)
5454
assertThat(options.sdkVersion!!.packageSet.map { pkg -> pkg.name })
55-
.contains("maven:io.sentry:sentry-spring-jakarta")
56-
assertThat(options.sdkVersion!!.integrationSet).contains("Spring6")
55+
.contains("maven:io.sentry:sentry-spring-7")
56+
assertThat(options.sdkVersion!!.integrationSet).contains("Spring7")
5757
}
5858
}
5959

sentry-spring-boot-4/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ dependencies {
7777
testImplementation(projects.sentryReactor)
7878
testImplementation(projects.sentryTestSupport)
7979
testImplementation(kotlin(Config.kotlinStdLib))
80+
testImplementation(Config.Libs.kotlinReflect)
8081
testImplementation(platform(SpringBootPlugin.BOM_COORDINATES))
8182
testImplementation(libs.context.propagation)
8283
testImplementation(libs.kotlin.test.junit)

sentry-spring-boot-4/src/main/java/io/sentry/spring/boot/jakarta/SentryAutoConfiguration.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ public class SentryAutoConfiguration {
8888

8989
static {
9090
SentryIntegrationPackageStorage.getInstance()
91-
.addPackage("maven:io.sentry:sentry-spring-boot-starter-jakarta", BuildConfig.VERSION_NAME);
91+
.addPackage("maven:io.sentry:sentry-spring-boot-4-starter", BuildConfig.VERSION_NAME);
9292
}
9393

9494
/** Registers general purpose Sentry related beans. */
@@ -470,7 +470,7 @@ static class ApacheHttpClientTransportFactoryAutoconfiguration {
470470
}
471471

472472
private static void addPackageAndIntegrationInfo() {
473-
SentryIntegrationPackageStorage.getInstance().addIntegration("SpringBoot3");
473+
SentryIntegrationPackageStorage.getInstance().addIntegration("SpringBoot4");
474474
}
475475
}
476476

sentry-spring-boot-4/src/test/kotlin/io/sentry/spring/boot/jakarta/SentryAutoConfigurationTest.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ class SentryAutoConfigurationTest {
300300
fun `sets sentryClientName property on SentryOptions`() {
301301
contextRunner.withPropertyValues("sentry.dsn=http://key@localhost/proj").run {
302302
assertThat(it.getBean(SentryOptions::class.java).sentryClientName)
303-
.isEqualTo("sentry.java.spring-boot.jakarta/${BuildConfig.VERSION_NAME}")
303+
.isEqualTo("sentry.java.spring-boot-4/${BuildConfig.VERSION_NAME}")
304304
}
305305
}
306306

@@ -320,10 +320,10 @@ class SentryAutoConfigurationTest {
320320
assertThat(sdk.version).isEqualTo(BuildConfig.VERSION_NAME)
321321
assertThat(sdk.name).isEqualTo(BuildConfig.SENTRY_SPRING_BOOT_4_SDK_NAME)
322322
assertThat(sdk.packageSet).anyMatch { pkg ->
323-
pkg.name == "maven:io.sentry:sentry-spring-boot-starter-jakarta" &&
323+
pkg.name == "maven:io.sentry:sentry-spring-boot-4-starter" &&
324324
pkg.version == BuildConfig.VERSION_NAME
325325
}
326-
assertTrue(sdk.integrationSet.contains("SpringBoot3"))
326+
assertTrue(sdk.integrationSet.contains("SpringBoot4"))
327327
},
328328
anyOrNull(),
329329
)

0 commit comments

Comments
 (0)