perf(executor): Prewarm SentryExecutorService #4606

romtsn · 2025-08-05T09:17:51Z

📜 Description

Prewarm SentryExecutorService so we don't spend time for growing the internal task queue when it's full
Make SentryExecutorService bounded to 271 task (x8 times growth from the initial capacity), drop everything that's on top
Use LazyEvaluator for a couple of things I noticed were slowing down the init (e.g. instantiating a timer thread in LifecycleWatcher, when we actually only need it when finalizing a session)
Use HandlerThread for getting receiving broadcasts off-the-main-thread

💡 Motivation and Context

💚 How did you test it?

Manually + automated

📝 Checklist

I added tests to verify the changes.
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
I updated the docs if needed.
I updated the wizard if needed.
Review from the native team if needed.
No breaking change or entry added to the changelog.
No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

…PC calls

…acks when launched with background importance

Co-authored-by: Markus Hintersteiner <[email protected]>

Co-authored-by: roman.zavarnitsyn <[email protected]>

github-actions · 2025-08-05T09:50:45Z

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	378.38 ms	399.86 ms	21.48 ms
Size	1.58 MiB	2.09 MiB	522.32 KiB

Previous results on branch: rz/perf/enhanced-executor-service

Startup times

Revision	Plain	With Sentry	Diff
`018e963`	419.07 ms	463.71 ms	44.64 ms
`68427d3`	431.89 ms	476.85 ms	44.96 ms

App size

Revision	Plain	With Sentry	Diff
`018e963`	1.58 MiB	2.09 MiB	521.49 KiB
`68427d3`	1.58 MiB	2.09 MiB	522.15 KiB

markushi

Looking good, nice work! I left a few small-ish comments.

markushi · 2025-08-07T05:50:28Z

sentry/src/main/java/io/sentry/SentryExecutorService.java

+    if (executorService.getQueue().size() < MAX_QUEUE_SIZE) {
+      return executorService.submit(runnable);
+    }
+    // TODO: maybe RejectedExecutionException?


Yes, I'd say so, when we did the SDK restart work we should have accounted for RejectedExecutionException everywhere.

I've seen some instances where we don't handle it (e.g. here), so I'd rather do that in a separate PR later with fixing RejectedExecutionException along the way

sentry/src/main/java/io/sentry/SentryExecutorService.java

* Do not report cached events as lost * E2E tests for OpenTelemetry based console sample (#4563) * e2e tests for console app * fix test failures by waiting for 10s after first try to find envelopes * add system-test-runner.py script to replace bash scripts for running e2e / system tests * use py script for ci, cleanup, makefile * Format code * remove bash scripts * install requests module * api * fix gh script * Implement E2E tests for OTel based console sample * fixes after merge * Format code * e2e tests for console app * Implement E2E tests for OTel based console sample * fixes after merge * Format code * api * Reduce scope forking when using OpenTelemetry (#4565) * Reduce scope forking in OpenTelemetry * Format code * api * changelog --------- Co-authored-by: Sentry Github Bot <[email protected]> * SDKs send queue is no longer shutdown immediately on re-init (#4564) * Let queue drain on a restart * Format code * Format code * Update sentry-samples/sentry-samples-console-opentelemetry-noagent/src/test/kotlin/sentry/systemtest/ConsoleApplicationSystemTest.kt * Let queue drain on a restart * Format code * Format code * Update sentry-samples/sentry-samples-console-opentelemetry-noagent/src/test/kotlin/sentry/systemtest/ConsoleApplicationSystemTest.kt * adapt tests * changelog --------- Co-authored-by: Sentry Github Bot <[email protected]> --------- Co-authored-by: Sentry Github Bot <[email protected]> * release: 8.18.0 * ref(replay): Use main thread to schedule capture (#4542) * perf(connectivity): Cache network capabilities and status to reduce IPC calls (#4560) * fix(breadcrumbs): Deduplicate battery breadcrumbs (#4561) * fix(ci): remove obsolete NDK debug symbols (#4581) As they don't exist anymore and this is done within sentry-native directly: https://github.com/getsentry/sentry-native/pull/1327/files * fix(android): Remove unused method (#4585) * fix(android): Remove unused method * Update Changelog * Add rules file for documenting SDK offline behaviour (#4572) #skip-changelog ## 📜 Description  Add rules file for documenting SDK offline behaviour ## 💡 Motivation and Context   Should help speed up AI reasoning about the SDK offline/retry behaviour. ## 💚 How did you test it? ## 📝 Checklist  - [ ] I added tests to verify the changes. - [ ] No new PII added or SDK only sends newly added PII if `sendDefaultPII` is enabled. - [ ] I updated the docs if needed. - [ ] I updated the wizard if needed. - [ ] Review from the native team if needed. - [ ] No breaking change or entry added to the changelog. - [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs. ## 🔮 Next steps * perf(connectivity): Have only one NetworkCallback active at a time (#4562) * fix(scripts): update-gradle script set-version (#4591) * fix: sentry-android-ndk proguard rule keeps all native class (#4427) * fix: sentry-androi-ndk proguard rule keeps all native class * docs: update CHANGELOG * fix: update CHANGELOG * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Markus Hintersteiner <[email protected]> Co-authored-by: Markus Hintersteiner <[email protected]> * refactor(lifecycle): Use single lifecycle observer (#4567) * perf(connectivity): Cache network capabilities and status to reduce IPC calls * changelog * Changelog * revert * fix(breadcrumbs): Deduplicate battery breadcrumbs * ref * Changelog * Fix test * perf(connectivity): Have only one NetworkCallback active at a time * Changelog * perf(integrations): Use single lifecycle observer * Add tests * Changelog * Fix tests * Improve callback handling and test visibility (#4593) * Null-check lifecycleObserver --------- Co-authored-by: Markus Hintersteiner <[email protected]> * fix(sqlite): Fix abstract method error (#4597) * fix(sqlite): Fix abstract method error * Update CHANGELOG.md * Suppress metadata version checks * perf(integrations): Do not register for SystemEvents and NetworkCallbacks when launched with background importance (#4579) * fix(android): Ensure frame metrics listeners are registered/unregistered on the main thread (#4582) * fix(android): Ensure frame metrics listeners are registered/unregistered on the main thread * Fix race conditions * Update Changelog * Update CHANGELOG.md * Address PR feedback * perf(executor): Prewarm SentryExecutorService (#4606) * review feedback * changelog * pass through whether cache stored in AndroidEnvelopeCache + test * Format code --------- Co-authored-by: Sentry Github Bot <[email protected]> Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: Roman Zavarnitsyn <[email protected]> Co-authored-by: Markus Hintersteiner <[email protected]> Co-authored-by: Ghasem Shirdel <[email protected]> Co-authored-by: Markus Hintersteiner <[email protected]>

romtsn and others added 30 commits July 16, 2025 12:34

perf(connectivity): Cache network capabilities and status to reduce I…

2a0d6da

…PC calls

Merge branch 'main' into rz/perf/less-ipc

0ac3081

changelog

14bb2d5

Changelog

c82586d

revert

7418781

fix(breadcrumbs): Deduplicate battery breadcrumbs

f739d00

ref

833b026

Changelog

e4596ff

Fix test

0153ab5

Merge branch 'rz/perf/less-ipc' into rz/fix/diff-battery-crumbs

15794c6

perf(connectivity): Have only one NetworkCallback active at a time

c31d648

Changelog

83d80d7

perf(integrations): Use single lifecycle observer

5b32662

Add tests

5c5238a

Changelog

d2263b8

Fix tests

42ff8e9

perf(integrations): Do not register for SystemEvents and NetworkCallb…

fde11a2

…acks when launched with background importance

Do not cache importance

bba4efe

Revert SR

5edb0d3

Add tests

d8402b6

Spotless

b7a5e0a

Comment

c7cad14

Revert profiling

8a6f145

Changelog

d868d1a

fix test name

c890fe3

Update sentry-samples/sentry-samples-android/sdkperf/README.md

900ecb5

Update sentry-samples/sentry-samples-android/sdkperf/README.md

ac613d6

Update sentry-samples/sentry-samples-android/sdkperf/README.md

85f5bae

Update sentry-samples/sentry-samples-android/sdkperf/screen_flap.sh

3f3a499

Co-authored-by: Markus Hintersteiner <[email protected]>

Update sentry-samples/sentry-samples-android/sdkperf/wifi_flap.sh

c231dfc

Co-authored-by: Markus Hintersteiner <[email protected]>

romtsn added 2 commits August 4, 2025 23:34

Prewarm SentryExecutorService and make it bounded

9b55d06

Use HandlerThread for receiving broadcasts

d20ab34

romtsn requested review from adinauer, stefanosiano, markushi and lcian as code owners August 5, 2025 09:17

Changelog

a5702e0

This comment was marked as outdated.

Sign in to view

Update registerReceiver method calls to match Android SDK changes

a0e161a

Co-authored-by: roman.zavarnitsyn <[email protected]>

This comment was marked as outdated.

Sign in to view

Format code

74bc8a6

Base automatically changed from rz/perf/no-network-on-background to main August 6, 2025 09:53

romtsn added 3 commits August 6, 2025 14:43

Merge branch 'main' into rz/perf/enhanced-executor-service

026d34a

Add a comment

c2447df

Do not leak HandlerThread in SystemEventsReceiver

36482b9

This comment was marked as outdated.

Sign in to view

romtsn added 3 commits August 6, 2025 16:44

Null-check handlerThread

194ee54

Clear the queue in a different task

9021c78

Formatting

0e6a1f4

romtsn force-pushed the rz/perf/enhanced-executor-service branch from ba56765 to 0e6a1f4 Compare August 6, 2025 14:56

This comment was marked as outdated.

Sign in to view

markushi approved these changes Aug 7, 2025

View reviewed changes

romtsn added 2 commits August 7, 2025 11:34

Cancel tasks and purge them

face071

Merge branch 'main' into rz/perf/enhanced-executor-service

d46bbc0

romtsn enabled auto-merge (squash) August 7, 2025 13:33

romtsn merged commit 72b3637 into main Aug 7, 2025
34 of 35 checks passed

romtsn deleted the rz/perf/enhanced-executor-service branch August 7, 2025 13:37

adinauer pushed a commit that referenced this pull request Aug 8, 2025

perf(executor): Prewarm SentryExecutorService (#4606)

2c7271a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

perf(executor): Prewarm SentryExecutorService #4606

perf(executor): Prewarm SentryExecutorService #4606

Uh oh!

romtsn commented Aug 5, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Aug 5, 2025 •

edited

Loading

Previous results on branch: rz/perf/enhanced-executor-service

Startup times

App size

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

markushi left a comment

Uh oh!

markushi Aug 7, 2025

Uh oh!

romtsn Aug 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

perf(executor): Prewarm SentryExecutorService #4606

perf(executor): Prewarm SentryExecutorService #4606

Uh oh!

Conversation

romtsn commented Aug 5, 2025

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance metrics 🚀

Previous results on branch: rz/perf/enhanced-executor-service

Startup times

App size

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

markushi left a comment

Choose a reason for hiding this comment

Uh oh!

markushi Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

romtsn Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 5, 2025 •

edited

Loading