Skip to content

Avoid StrictMode warnings #4724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Avoid StrictMode warnings #4724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95282db
SentryAndroid.init now sets strictMode to Lax and reset it after it f…
stefanosiano Sep 12, 2025
683bb3b
updated changelog
stefanosiano Sep 12, 2025
3f3eb00
restored old policy in finally block
stefanosiano Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@
}
```

### Fixes

- Avoid StrictMode warnings ([#4724](https://github.com/getsentry/sentry-java/pull/4724))

### Improvements

- Remove internal API status from get/setDistinctId ([#4708](https://github.com/getsentry/sentry-java/pull/4708))
Expand Down
8 changes: 8 additions & 0 deletions sentry-android-core/src/main/java/io/sentry/android/core/SentryAndroid.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import android.app.Application;
import android.content.Context;
import android.os.Process;
import android.os.StrictMode;
import android.os.SystemClock;
import io.sentry.ILogger;
import io.sentry.IScopes;
Expand Down Expand Up @@ -93,6 +94,10 @@ public static void init(
@NotNull final Context context,
@NotNull ILogger logger,
@NotNull Sentry.OptionsConfiguration<SentryAndroidOptions> configuration) {
final @NotNull StrictMode.ThreadPolicy oldPolicy = StrictMode.getThreadPolicy();
final @NotNull StrictMode.VmPolicy oldVmPolicy = StrictMode.getVmPolicy();
StrictMode.setThreadPolicy(StrictMode.ThreadPolicy.LAX);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I'm thinking this is too relaxing - e.g. the user init config (line 142) will also be under the LAX policy now, which is not what we want probably (e.g. if the user does I/O inside the init { } block this would not be flagged anymore). Can we be more specific and only wrap the actual offending calls into LAX?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was also thinking about resetting the policies before the config init (user callback) and then set it back to lax until the end of init()
Wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that probably could do, but we're risking suppressing any new issues that might will have been introduced in the future outside the current ones. I'd really prefer to only target specific issues and set LAX as tight as possible, if it's not a big lift.

StrictMode.setVmPolicy(StrictMode.VmPolicy.LAX);
try (final @NotNull ISentryLifecycleToken ignored = staticLock.acquire()) {
Sentry.init(
OptionsContainer.create(SentryAndroidOptions.class),
Expand Down Expand Up @@ -209,6 +214,9 @@ public static void init(
logger.log(SentryLevel.FATAL, "Fatal error during SentryAndroid.init(...)", e);

throw new RuntimeException("Failed to initialize Sentry's SDK", e);
} finally {
StrictMode.setThreadPolicy(oldPolicy);
StrictMode.setVmPolicy(oldVmPolicy);
}
}

Expand Down
17 changes: 9 additions & 8 deletions sentry-android-core/src/main/java/io/sentry/android/core/cache/AndroidEnvelopeCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import io.sentry.util.HintUtils;
import io.sentry.util.Objects;
import java.io.File;
import java.io.FileNotFoundException;
import java.io.FileOutputStream;
import java.io.OutputStream;
import org.jetbrains.annotations.ApiStatus;
Expand Down Expand Up @@ -157,18 +158,18 @@ public static boolean hasStartupCrashMarker(final @NotNull SentryOptions options

final File lastAnrMarker = new File(cacheDirPath, LAST_ANR_REPORT);
try {
if (lastAnrMarker.exists() && lastAnrMarker.canRead()) {
final String content = FileUtils.readText(lastAnrMarker);
// we wrapped into try-catch already
//noinspection ConstantConditions
return content.equals("null") ? null : Long.parseLong(content.trim());
} else {
final String content = FileUtils.readText(lastAnrMarker);
// we wrapped into try-catch already
//noinspection ConstantConditions
return content.equals("null") ? null : Long.parseLong(content.trim());
} catch (Throwable e) {
if (e instanceof FileNotFoundException) {
options
.getLogger()
.log(DEBUG, "Last ANR marker does not exist. %s.", lastAnrMarker.getAbsolutePath());
} else {
options.getLogger().log(ERROR, "Error reading last ANR marker", e);
}
} catch (Throwable e) {
options.getLogger().log(ERROR, "Error reading last ANR marker", e);
}
return null;
}
Expand Down
2 changes: 0 additions & 2 deletions sentry-android-core/src/main/java/io/sentry/android/core/internal/util/CpuInfoUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@ private CpuInfoUtils() {}
if (!cpuDir.getName().matches("cpu[0-9]+")) continue;
File cpuMaxFreqFile = new File(cpuDir, CPUINFO_MAX_FREQ_PATH);

if (!cpuMaxFreqFile.exists() || !cpuMaxFreqFile.canRead()) continue;

long khz;
try {
String content = FileUtils.readText(cpuMaxFreqFile);
Expand Down
8 changes: 8 additions & 0 deletions ...tests/sentry-uitest-android/src/androidTest/java/io/sentry/uitest/android/SdkInitTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package io.sentry.uitest.android

import android.os.StrictMode
import androidx.lifecycle.Lifecycle
import androidx.test.core.app.launchActivity
import androidx.test.ext.junit.runners.AndroidJUnit4
Expand Down Expand Up @@ -269,6 +270,13 @@ class SdkInitTests : BaseUiTest() {
assertDefaultIntegrations()
}

@Test
fun initNotThrowStrictMode() {
StrictMode.setThreadPolicy(StrictMode.ThreadPolicy.Builder().detectAll().penaltyDeath().build())
StrictMode.setVmPolicy(StrictMode.VmPolicy.Builder().detectAll().penaltyDeath().build())
initSentry()
}

private fun assertDefaultIntegrations() {
val integrations =
mutableListOf(
Expand Down
24 changes: 6 additions & 18 deletions sentry/src/main/java/io/sentry/DirectoryProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,34 +40,22 @@ public void processDirectory(final @NotNull File directory) {
try {
logger.log(SentryLevel.DEBUG, "Processing dir. %s", directory.getAbsolutePath());

if (!directory.exists()) {
final File[] filteredListFiles = directory.listFiles((d, name) -> isRelevantFileName(name));
if (filteredListFiles == null) {
logger.log(
SentryLevel.WARNING,
"Directory '%s' doesn't exist. No cached events to send.",
SentryLevel.ERROR,
"Cache dir %s is null or is not a directory.",
directory.getAbsolutePath());
return;
}
if (!directory.isDirectory()) {
logger.log(
SentryLevel.ERROR, "Cache dir %s is not a directory.", directory.getAbsolutePath());
return;
}

final File[] listFiles = directory.listFiles();
if (listFiles == null) {
logger.log(SentryLevel.ERROR, "Cache dir %s is null.", directory.getAbsolutePath());
return;
}

final File[] filteredListFiles = directory.listFiles((d, name) -> isRelevantFileName(name));

logger.log(
SentryLevel.DEBUG,
"Processing %d items from cache dir %s",
filteredListFiles != null ? filteredListFiles.length : 0,
filteredListFiles.length,
directory.getAbsolutePath());

for (File file : listFiles) {
for (File file : filteredListFiles) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found we were filtering the files in the directory, but then looped over all the files anyway
Was it by design or by accident?
And is there any risk in changing this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure that was an oversight. IMHO the risk is low as all non-envelope files will fail to be parsed / sent anyway.

// it ignores .sentry-native database folder and new ones that might come up
if (!file.isFile()) {
logger.log(SentryLevel.DEBUG, "File %s is not a File.", file.getAbsolutePath());
Expand Down
15 changes: 7 additions & 8 deletions sentry/src/main/java/io/sentry/cache/EnvelopeCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,18 +336,17 @@ public void discard(final @NotNull SentryEnvelope envelope) {
Objects.requireNonNull(envelope, "Envelope is required.");

final File envelopeFile = getEnvelopeFile(envelope);
if (envelopeFile.exists()) {
if (envelopeFile.delete()) {
options
.getLogger()
.log(DEBUG, "Discarding envelope from cache: %s", envelopeFile.getAbsolutePath());

if (!envelopeFile.delete()) {
options
.getLogger()
.log(ERROR, "Failed to delete envelope: %s", envelopeFile.getAbsolutePath());
}
} else {
options.getLogger().log(DEBUG, "Envelope was not cached: %s", envelopeFile.getAbsolutePath());
options
.getLogger()
.log(
DEBUG,
"Envelope was not cached or could not be deleted: %s",
envelopeFile.getAbsolutePath());
}
}

Expand Down
11 changes: 6 additions & 5 deletions sentry/src/test/java/io/sentry/EnvelopeSenderTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ class EnvelopeSenderTest {
val sut = fixture.getSut()
sut.processDirectory(File("i don't exist"))
verify(fixture.logger)!!.log(
eq(SentryLevel.WARNING),
eq("Directory '%s' doesn't exist. No cached events to send."),
eq(SentryLevel.ERROR),
eq("Cache dir %s is null or is not a directory."),
any<Any>(),
)
verifyNoMoreInteractions(fixture.scopes)
Expand All @@ -79,14 +79,14 @@ class EnvelopeSenderTest {
sut.processDirectory(testFile)
verify(fixture.logger)!!.log(
eq(SentryLevel.ERROR),
eq("Cache dir %s is not a directory."),
eq("Cache dir %s is null or is not a directory."),
any<Any>(),
)
verifyNoMoreInteractions(fixture.scopes)
}

@Test
fun `when directory has non event files, processDirectory logs that`() {
fun `when directory has non event files, processDirectory skips them`() {
val sut = fixture.getSut()
val testFile =
File(
Expand All @@ -96,7 +96,8 @@ class EnvelopeSenderTest {
testFile.deleteOnExit()
verify(fixture.logger)!!.log(
eq(SentryLevel.DEBUG),
eq("File '%s' doesn't match extension expected."),
eq("Processing %d items from cache dir %s"),
eq(0),
any<Any>(),
)
verify(fixture.scopes, never())!!.captureEnvelope(any(), anyOrNull())
Expand Down
Loading