Skip to content

[do not merge] Remove databag trimming #4645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: potel-base
Choose a base branch
from

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jul 30, 2025

  • remove databag breadth/depth trimming completely
  • remove associated serializer args (remaining_depth, remaining_breadth)
  • set max_request_body_size to "always" by default

About the do-not-merge: We want to dogfood this separately, after we're confident the other SDK changes are ok.

Ref #4172

Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.93%. Comparing base (146f101) to head (59ee530).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@              Coverage Diff               @@
##           potel-base    #4645      +/-   ##
==============================================
- Coverage       84.99%   84.93%   -0.07%     
==============================================
  Files             158      158              
  Lines           15519    15495      -24     
  Branches         2456     2447       -9     
==============================================
- Hits            13191    13160      -31     
- Misses           1573     1580       +7     
  Partials          755      755              
Files with missing lines Coverage Δ
sentry_sdk/client.py 84.88% <ø> (ø)
sentry_sdk/consts.py 99.67% <ø> (ø)
sentry_sdk/integrations/pure_eval.py 70.27% <100.00%> (ø)
sentry_sdk/serializer.py 100.00% <100.00%> (+2.24%) ⬆️

... and 4 files with indirect coverage changes

@sentrivana sentrivana force-pushed the ivana/potel/bump-trimming branch from 5a8898d to 4ebc62f Compare July 30, 2025 14:41
@sentrivana sentrivana marked this pull request as ready for review July 31, 2025 07:49
@sentrivana sentrivana requested a review from a team as a code owner July 31, 2025 07:49
@sentrivana sentrivana changed the title Remove databag trimming [do not merge] Remove databag trimming Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants