Skip to content

Manual instrumentation improvements #4648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Jul 30, 2025

Manual instrumentation for insights module is cumbersome. Update the @trace decorator and make it more powerful. Also add a sentry_sdk.update_current_span(op, name, attributes).

This creates better DX for our users.

Copy link

codecov bot commented Jul 30, 2025

Codecov Report

❌ Patch coverage is 47.82609% with 96 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.65%. Comparing base (84adbb7) to head (2011ab4).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/tracing_utils.py 44.96% 68 Missing and 14 partials ⚠️
sentry_sdk/api.py 18.18% 9 Missing ⚠️
sentry_sdk/tracing.py 73.33% 2 Missing and 2 partials ⚠️
sentry_sdk/consts.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4648      +/-   ##
==========================================
- Coverage   85.09%   84.65%   -0.44%     
==========================================
  Files         156      156              
  Lines       15797    15944     +147     
  Branches     2671     2723      +52     
==========================================
+ Hits        13442    13498      +56     
- Misses       1578     1654      +76     
- Partials      777      792      +15     
Files with missing lines Coverage Δ
sentry_sdk/__init__.py 100.00% <ø> (ø)
sentry_sdk/consts.py 99.32% <88.88%> (-0.33%) ⬇️
sentry_sdk/tracing.py 86.02% <73.33%> (-0.45%) ⬇️
sentry_sdk/api.py 84.72% <18.18%> (-5.58%) ⬇️
sentry_sdk/tracing_utils.py 74.62% <44.96%> (-12.12%) ⬇️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant