feat(sampleApps): Update sample apps to React Native 0.80, update other dependencies, improve code quality #5057
+2,507
−1,436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eb07ba3+dirty | 419.49 ms | 482.12 ms | 62.63 ms |
| 534ba8c+dirty | 472.35 ms | 537.31 ms | 64.96 ms |
| 3e0a5f9+dirty | 379.92 ms | 450.96 ms | 71.04 ms |
| d916aa3+dirty | 411.72 ms | 451.76 ms | 40.03 ms |
| 785ffb1+dirty | 380.65 ms | 451.83 ms | 71.18 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eb07ba3+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 534ba8c+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 3e0a5f9+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| d916aa3+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 785ffb1+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3e0a5f9+dirty | 1226.94 ms | 1230.02 ms | 3.08 ms |
| eb07ba3+dirty | 1222.46 ms | 1220.37 ms | -2.08 ms |
| d916aa3+dirty | 1221.02 ms | 1228.98 ms | 7.96 ms |
| 785ffb1+dirty | 1237.63 ms | 1240.50 ms | 2.87 ms |
| 534ba8c+dirty | 1230.22 ms | 1231.18 ms | 0.96 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3e0a5f9+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| eb07ba3+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| d916aa3+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 785ffb1+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 534ba8c+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3e0a5f9+dirty | 1233.65 ms | 1239.10 ms | 5.45 ms |
| eb07ba3+dirty | 1214.49 ms | 1221.59 ms | 7.10 ms |
| d916aa3+dirty | 1211.02 ms | 1221.33 ms | 10.31 ms |
| 785ffb1+dirty | 1213.71 ms | 1213.37 ms | -0.35 ms |
| 534ba8c+dirty | 1225.00 ms | 1237.43 ms | 12.43 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3e0a5f9+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| eb07ba3+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| d916aa3+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 785ffb1+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 534ba8c+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
alwx
force-pushed
the
alwx/improvement/sample-apps
branch
from
86c75f1 to
86a520f
Compare
alwx
changed the title
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eb07ba3 | 470.04 ms | 473.35 ms | 3.31 ms |
| 3e0a5f9 | 401.72 ms | 394.98 ms | -6.74 ms |
| 534ba8c | 484.00 ms | 499.93 ms | 15.93 ms |
| d916aa3 | 425.37 ms | 427.02 ms | 1.65 ms |
| 785ffb1 | 471.92 ms | 460.96 ms | -10.96 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eb07ba3 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 3e0a5f9 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 534ba8c | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| d916aa3 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 785ffb1 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
alwx
force-pushed
the
alwx/improvement/sample-apps
branch
from
5db30fb to
b1d66e9
Compare
| @@ -8,6 +8,8 @@ | |||
| ## Unreleased | |||
|
|
|||
| - Update the sample app to React Native 0.80, update other dependencies, improve code quality of the sample app ([#5057](https://github.com/getsentry/sentry-react-native/pull/5057)) | |||
There was a problem hiding this comment.
We usually omit internal changes like sample update.
|
|
||
| interface Props { | ||
| navigation: StackNavigationProp<any, 'HeavyNatigavionScreen'>; | ||
| navigation: StackNavigationProp<any, 'HeavyNavigationScreen'>; |
|
Q: Have you checked if the sample app is building on iOS? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4941
Includes:
react-native-vector-iconsversion bump (with the updated imports)@toolkit/redux)/src/tabsSentry.getCurrentHub()(not supported anymore because of OpenTelemetry)WebviewScreenwhich was disabled due to issues with RN 0.79RCTNewArchEnabledadded toInfo.plistImportant things to know:
react-native-macos— the latest supported version is 0.78 (https://github.com/microsoft/react-native-macos/releases)