3 issues
code-review: Found 3 issues (1 high, 1 medium, 1 low)
High
Public AI helper exports removed without RN migration path - `packages/core/etc/sentry-react-native.api.md:152-160`
Removing CompiledGraph and createLangChainCallbackHandler from the public API breaks existing RN imports; document the break and a migration (or re-export/shim) before shipping.
Also found at:
packages/core/etc/sentry-react-native.api.md:396-418packages/core/etc/sentry-react-native.api.md:490-495packages/core/src/js/index.ts:50-62packages/core/etc/sentry-react-native.api.md:104-109
Medium
TS type-check no longer validates published ts3.8 types - `dev-packages/type-check/ts5.0-test/package.json:1-17`
This suite now type-checks only with TypeScript 5.0.4, so it no longer exercises the still-published typesVersions/ts3.8 downlevel path for TS < 4.9; keep a TS < 4.9 check or drop that support path together.
Low
No test asserts default traceLifecycle is static - `packages/core/src/js/sdk.tsx:66-70`
Add an init() default assertion for traceLifecycle: 'static' (same pattern as propagateTraceparent is false by default) so a future core default flip cannot silently reintroduce stream lifecycle for mobile.
⏱ 13m 2s · 4.7M in / 180.6k out · $6.33
Annotations
Check failure on line 160 in packages/core/etc/sentry-react-native.api.md
sentry-warden / warden: code-review
Public AI helper exports removed without RN migration path
Removing `CompiledGraph` and `createLangChainCallbackHandler` from the public API breaks existing RN imports; document the break and a migration (or re-export/shim) before shipping.
Check failure on line 418 in packages/core/etc/sentry-react-native.api.md
sentry-warden / warden: code-review
[5NC-8LN] Public AI helper exports removed without RN migration path (additional location)
Removing `CompiledGraph` and `createLangChainCallbackHandler` from the public API breaks existing RN imports; document the break and a migration (or re-export/shim) before shipping.
Check failure on line 495 in packages/core/etc/sentry-react-native.api.md
sentry-warden / warden: code-review
[5NC-8LN] Public AI helper exports removed without RN migration path (additional location)
Removing `CompiledGraph` and `createLangChainCallbackHandler` from the public API breaks existing RN imports; document the break and a migration (or re-export/shim) before shipping.
Check failure on line 62 in packages/core/src/js/index.ts
sentry-warden / warden: code-review
[5NC-8LN] Public AI helper exports removed without RN migration path (additional location)
Removing `CompiledGraph` and `createLangChainCallbackHandler` from the public API breaks existing RN imports; document the break and a migration (or re-export/shim) before shipping.
Check failure on line 109 in packages/core/etc/sentry-react-native.api.md
sentry-warden / warden: code-review
[5NC-8LN] Public AI helper exports removed without RN migration path (additional location)
Removing `CompiledGraph` and `createLangChainCallbackHandler` from the public API breaks existing RN imports; document the break and a migration (or re-export/shim) before shipping.
Check warning on line 17 in dev-packages/type-check/ts5.0-test/package.json
sentry-warden / warden: code-review
TS type-check no longer validates published ts3.8 types
This suite now type-checks only with TypeScript 5.0.4, so it no longer exercises the still-published `typesVersions`/`ts3.8` downlevel path for TS < 4.9; keep a TS < 4.9 check or drop that support path together.