Add support for unreal's additional crash context scopes #1052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
...ev/Source/Sentry/Private/GenericPlatform/CrashReporter/GenericPlatformSentryCrashContext.cpp
Show resolved
Hide resolved
redxdev
commented
Aug 15, 2025
...ev/Source/Sentry/Private/GenericPlatform/CrashReporter/GenericPlatformSentryCrashContext.cpp
Outdated
Show resolved
Hide resolved
|
Hey @redxdev, thank you for submitting this PR! We'll be looking forward to Epics accepting you're changes to the engine and also explore if there's more context data we can add like that. |
|
Looks like epic grabbed the required commit on their side: https://github.com/EpicGames/UnrealEngine/commit/8d79c7e26943f5c3c3ad1291db25488215fa8b09 I've updated the review to check for a minimum version of 5.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires Epic to accept https://github.com/EpicGames/UnrealEngine/pull/13686 first as one required method is not exported from
Core.Unreal has a little-known macro
UE_ADD_CRASH_CONTEXT_SCOPEwhich allows running code to add additional information to a crash if the crash happens within the scope the macro is in. This adds support to sentry to retrieve this information and add it as an additional scope. Some other systems may also add data into this viaOnAdditionalCrashContextDelegate().