-
-
Notifications
You must be signed in to change notification settings - Fork 50
feat: Implement structured logging for Unreal (all platforms) #1091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
plugin-dev/Source/Sentry/Private/Android/Java/SentryBridgeJava.java
Outdated
Show resolved
Hide resolved
24ef528
to
5b950d9
Compare
plugin-dev/Source/Sentry/Private/GenericPlatform/GenericPlatformSentryLog.cpp
Show resolved
Hide resolved
plugin-dev/Source/Sentry/Private/GenericPlatform/GenericPlatformSentrySubsystem.cpp
Outdated
Show resolved
Hide resolved
plugin-dev/Source/Sentry/Private/GenericPlatform/GenericPlatformSentrySubsystem.h
Outdated
Show resolved
Hide resolved
Hey @nwhite-riot, thanks for taking a look! I will address your code comments in the next rev, but on a more general note: yes we want this enabled on consoles too, but what was meant with “all platforms” is all platforms in this repo. As soon as this PR is done, I am going to follow up with all console plugin integrations in other repos (breaking changes for init). Regarding naming: as you might see I was trying different things out, but sticking with one name makes more sense. I will think about it a little more. |
3f3a37d
to
af7659c
Compare
Note
Adds structured logging across Android, Apple, and Native platforms with a new beforeLog hook, log APIs, settings, and output-device integration.
AddLog
API toISentrySubsystem
and platform subsystems (Android/Apple/Native); route level-specific logs to SDKs.beforeLog
/BeforeSendLog
callbacks (JNI/Cocoa/Native) and wire through bridges (SentryBridgeJava
, JNI, Cocoa options).options.getLogs().setEnabled
,options.enableLogs
,sentry_options_set_enable_logs
).ISentryLog
andUSentryLog
types; newUSentryBeforeLogHandler
for pre-processing logs.ISentrySubsystem::InitWithSettings
to acceptUSentryBeforeLogHandler*
.EnableStructuredLogging
, category filters, per-level forwarding (FStructuredLoggingLevels
), and "Also send breadcrumbs" toggle; propagate to platform init.FSentryOutputDevice
to forwardUE_LOG
to structured logging (with category filtering) and optionally send breadcrumbs.FAndroidSentryLog
,FAppleSentryLog
,FGenericPlatformSentryLog
) and HAL includes.Written by Cursor Bugbot for commit 2bf68e8. This will update automatically on new commits. Configure here.