feat(sveltekit): Set sendDefaultPii: true by default #1055
+274
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1055 +/- ##
==========================================
+ Coverage 32.12% 32.39% +0.26%
==========================================
Files 133 133
Lines 15696 15698 +2
Branches 1100 1107 +7
==========================================
+ Hits 5042 5085 +43
+ Misses 10637 10596 -41
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
onurtemizkan
force-pushed
the
onur/senddefaultpii-sveltekit
branch
from
9005656 to
7c78ed8
Compare
Lms24
reviewed
Oct 2, 2025
test/sveltekit/templates.test.ts
Outdated
Comment on lines
277
to
285
| expect(result).toContain('import * as Sentry from "@sentry/sveltekit";'); | ||
| expect(result).toContain('dsn: "https://sentry.io/123"'); | ||
| expect(result).toContain('tracesSampleRate: 1'); | ||
| expect(result).toContain('replaysSessionSampleRate: 0.1'); | ||
| expect(result).toContain('replaysOnErrorSampleRate: 1'); | ||
| expect(result).toContain('enableLogs: true'); | ||
| expect(result).toContain('sendDefaultPii: true'); | ||
| expect(result).toContain('integrations: [Sentry.replayIntegration()]'); | ||
| expect(result).toContain('Sentry.init({'); |
There was a problem hiding this comment.
Thanks for adding the tests, much appreciated! Can we use toMatchInlineSnapshot instead of the infividual contain assertions?
happy to stay with this if there's a good reason for it otherwise
(same q for the other tests below)
|
Please also rebase the PR, thanks! |
|
@Lms24 - Updated 👍 |
onurtemizkan
force-pushed
the
onur/senddefaultpii-sveltekit
branch
from
7c78ed8 to
46d4b0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #959