Skip to content

ref(objectstore): Stop using sentry.options internally #102080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ref(objectstore): Stop using sentry.options internally #102080

wants to merge 2 commits into from
+17 −12

Conversation

@lcian
Copy link
Member

@lcian lcian commented Oct 24, 2025 •
edited
Loading

Adds a required first param objectstore_base_url to objectstore.ClientBuilder.
Stops using sentry.option internally, instead moves its use to __init__.py where attachments is defined, so that other modules can keep importing attachments without any changes.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 24, 2025
lcian
lcian commented Oct 24, 2025
View reviewed changes
src/sentry/objectstore/service.py


class Client:
_default_compression: Compression
Copy link
Member Author

@lcian lcian Oct 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added to stop pyright from complaining, it considered this to be a str

@lcian lcian marked this pull request as ready for review October 24, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lcian