fix(timeseries): Improve parsing of null groups #102087
Merged
+22
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
nsdeschenes
approved these changes
Oct 27, 2025
obostjancic
approved these changes
Oct 28, 2025
gggritso
deleted the
georgegritsouk/eng-5769-fix-treatment-of-null-groups-during-conversion
branch
priscilawebdev
pushed a commit
that referenced
this pull request
Oct 29, 2025
Unlike `/events-timeseries/`, `/events-stats/` has an issue where a `null` group gets converted to `"None"` by stringifying that key in Python. This is a mismatch between the endpoints, and I'm resolving it here by correctly accounting for `"None"` as a key. I've also taken this opportunity to improve how `null` groups are handled. They are now showns as `"(no value)"` in more places. N.B. Checking for `"null"` in the `ModelName` is a hack, sorry! It's due to how the code is arranged. `ModelName` is used in a field renderer, which checks the data values beforehand. It's also used directly by some table components, where checking the value is a little more annoying. I opted to check for `"null"`, so it's all in once place. We could make this situation a lot better by using the field renderers in the table widgets! With this fix, the values in the chart tooltips and table values in Explore and the AI modules work correctly. **e.g.,** <img width="168" height="419" alt="Screenshot 2025-10-24 at 12 08 28 PM" src="https://github.com/user-attachments/assets/70bf6f59-7981-475b-b042-3cad7e939db7" /> <img width="356" height="296" alt="Screenshot 2025-10-24 at 12 10 35 PM" src="https://github.com/user-attachments/assets/ddc7c466-23dd-4ef4-aa79-78b29a0d7e90" /> <img width="178" height="216" alt="Screenshot 2025-10-24 at 12 54 15 PM" src="https://github.com/user-attachments/assets/836e4478-fb5c-45f2-9922-d372124c56f7" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike
/events-timeseries/,/events-stats/has an issue where anullgroup gets converted to"None"by stringifying that key in Python. This is a mismatch between the endpoints, and I'm resolving it here by correctly accounting for"None"as a key. I've also taken this opportunity to improve hownullgroups are handled. They are now showns as"(no value)"in more places.N.B. Checking for
"null"in theModelNameis a hack, sorry! It's due to how the code is arranged.ModelNameis used in a field renderer, which checks the data values beforehand. It's also used directly by some table components, where checking the value is a little more annoying. I opted to check for"null", so it's all in once place.We could make this situation a lot better by using the field renderers in the table widgets!
With this fix, the values in the chart tooltips and table values in Explore and the AI modules work correctly.
e.g.,
