fix/ref(search-bar): Inline replace rather than merge and replace #102098
+130
−186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
malwilley
approved these changes
Oct 24, 2025
nsdeschenes
force-pushed
the
nd/chore-do-not-merge-auto-replace-values
branch
from
106cf89 to
8b7f09e
Compare
priscilawebdev
pushed a commit
that referenced
this pull request
Oct 28, 2025
…02098) This PR is an attempt to fix an issue @malwilley found when selecting `a or b`, by inline replacing rather than trying to merge and replace values. These changes remove the merging of all raw text values, as that would get into some strange behavior if users were building a complex query with parens or conditional operators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to fix an issue @malwilley found when selecting
a or b, by inline replacing rather than trying to merge and replace values.These changes remove the merging of all raw text values, as that would get into some strange behavior if users were building a complex query with parens or conditional operators.
Example:
Before:
Screen.Recording.2025-10-24.at.16.17.49.mov
After:
Screen.Recording.2025-10-24.at.15.24.27.mov