fix(aci): remove refs to open periods from unmerge task #102114
Conversation
github-actions
bot
added
the
Scope: Backend
![sentry-io[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| destination = Group.objects.get(id=destination_id) | ||
| destination.update(**get_group_backfill_attributes(caches, destination, events)) | ||
|
|
||
| update_open_periods(source, destination) | ||
| logger.info("migrate_events.migrate", extra={**extra, "destination_id": destination_id}) | ||
|
|
||
| if isinstance(args, InitialUnmergeArgs) or opt_eventstream_state is None: |
There was a problem hiding this comment.
Bug: Removing update_open_periods during error group unmerge causes destination groups to retain inconsistent open period data.
Severity: MEDIUM | Confidence: 0.90
🔍 Detailed Analysis
When two error groups are unmerged, the removal of the update_open_periods function prevents the destination group's open period data from being synchronized with the source group's data. This occurs because ErrorGroupType issues typically have open periods created by default. Consequently, the destination group retains stale or inconsistent open period information, which could affect workflow decisions or queries relying on this data.
💡 Suggested Fix
Reintroduce the call to update_open_periods or implement equivalent logic to synchronize open period data for the destination group during error group unmerge operations.
🤖 Prompt for AI Agent
Fix this bug. In src/sentry/tasks/unmerge.py at lines 202-207: When two error groups are
unmerged, the removal of the `update_open_periods` function prevents the destination
group's open period data from being synchronized with the source group's data. This
occurs because `ErrorGroupType` issues typically have open periods created by default.
Consequently, the destination group retains stale or inconsistent open period
information, which could affect workflow decisions or queries relying on this data.
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
Open period data doesn't matter for these groups. They don't use it.
2 participants
Merging/unmerging issues is only relevant to error issues. Open periods are not relevant to error issues.