Use clj-kondo config inside project, add :lint-as#76
Open
sritchie wants to merge 1 commit intogfredericks:masterfrom
Open
Use clj-kondo config inside project, add :lint-as#76sritchie wants to merge 1 commit intogfredericks:masterfrom
sritchie wants to merge 1 commit intogfredericks:masterfrom
Conversation
sritchie
commented
Jan 21, 2023
| @@ -1,4 +1,9 @@ | |||
| {:hooks | |||
| {:lint-as | |||
| {com.gfredericks.test.chuck.generators/for clojure.core/for | |||
Author
There was a problem hiding this comment.
I THINK these are correct, but please let me know if not.
Owner
There was a problem hiding this comment.
hmm, depends on what the assumption is
e.g., for has this :parallel clause, will that mess anything up?
(gen'/for [:parallel [n1 gen/nat
n2 gen/nat]
:when ^{:max-tries 20} (coprime? n1 n2)
:let [product (* n1 n2)]]
{:n product, :factors [n1 n2]})```
Author
There was a problem hiding this comment.
Yes, good call. I'll do a better job here and write a proper hook that we can ship with the library. Should get to this soon, thank you for the review!
Author
|
I am not sure i am going to be able to finish this anytime soon... Happy to keep it open for when I get to it but feel free to close /take this over if you're gardening. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a clj-kondo config to test.chuck proper, pointing at its own exported config.