Skip to content

Comments

Use clj-kondo config inside project, add :lint-as#76

Open
sritchie wants to merge 1 commit intogfredericks:masterfrom
sritchie:sritchie/kondo
Open

Use clj-kondo config inside project, add :lint-as#76
sritchie wants to merge 1 commit intogfredericks:masterfrom
sritchie:sritchie/kondo

Conversation

@sritchie
Copy link

This PR adds a clj-kondo config to test.chuck proper, pointing at its own exported config.

@@ -1,4 +1,9 @@
{:hooks
{:lint-as
{com.gfredericks.test.chuck.generators/for clojure.core/for
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I THINK these are correct, but please let me know if not.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, depends on what the assumption is

e.g., for has this :parallel clause, will that mess anything up?

(gen'/for [:parallel [n1 gen/nat
                      n2 gen/nat]
           :when ^{:max-tries 20} (coprime? n1 n2)
           :let [product (* n1 n2)]]
  {:n product, :factors [n1 n2]})```

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good call. I'll do a better job here and write a proper hook that we can ship with the library. Should get to this soon, thank you for the review!

@sritchie
Copy link
Author

sritchie commented Mar 4, 2023

I am not sure i am going to be able to finish this anytime soon... Happy to keep it open for when I get to it but feel free to close /take this over if you're gardening. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants