-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Supporting Velvet model #11716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fbuciuni90
wants to merge
23
commits into
ggml-org:master
Choose a base branch
from
fbuciuni90:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+52
−0
Open
Supporting Velvet model #11716
Changes from 6 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
67b38f5
Supporting Velvet model
fbuciuni90 07e1d0a
Update convert_hf_to_gguf.py
fbuciuni90 99be555
Update convert_hf_to_gguf.py
fbuciuni90 3df9d22
Update include/llama.h
fbuciuni90 52b0bb3
Update src/llama-chat.cpp
fbuciuni90 9d86a04
removing whitespaces in src/lla-a-chat.cpp
fbuciuni90 66e6d10
fixing position of LLM_CHAT_TEMPLATE_VELVET in enum
fbuciuni90 3979557
updating velvet chat template
fbuciuni90 0a8995a
adding test case for velvet chat template
fbuciuni90 e8981aa
upadated llama-vocab.cpp with velvet case
fbuciuni90 c4c923a
attempt to fix pretokenization regex
fbuciuni90 50bf79b
fixed pre tokenization regex
fbuciuni90 308ef21
fixed chat template
fbuciuni90 22257d8
Merge branch 'master' into master
fbuciuni90 8e6b29e
Merge branch 'master' into master
fbuciuni90 8c57157
Merge branch 'master' into master
fbuciuni90 a7c4895
Merge branch 'ggml-org:master' into master
fbuciuni90 bc15f90
fix typo in llama-vocab.cpp caused by merge
fbuciuni90 bd0ffeb
fix indentation tab issue
fbuciuni90 c516dbd
fix chat template test caused by sync
fbuciuni90 a78b983
small fix in chat template test
fbuciuni90 ac6206c
Merge branch 'master' into master
fbuciuni90 4e743d8
Merge branch 'ggml-org:master' into master
fbuciuni90 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's also recommended to add a test for this chat template, see
test-chat-template.cpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, this enum value is in the incorrect place. everything must come before
LLM_CHAT_TEMPLATE_UNKNOWN
please also add a test case in
test-chat-template.cpp
. Otherwise you will expect it to be broken in the futureThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the test case for chat template as you suggested and I did the requested changes. Let me know if I still missing something. Thanks.