-
Notifications
You must be signed in to change notification settings - Fork 12.6k
model: add hunyuan dense #14878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
model: add hunyuan dense #14878
Conversation
Signed-off-by: stevenkuang <[email protected]>
Signed-off-by: stevenkuang <[email protected]>
Signed-off-by: stevenkuang <[email protected]>
Signed-off-by: stevenkuang <[email protected]>
This reverts commit aa973ca.
Signed-off-by: stevenkuang <[email protected]>
Signed-off-by: stevenkuang <[email protected]>
Signed-off-by: stevenkuang <[email protected]>
Signed-off-by: stevenkuang <[email protected]>
@stevenkuang-tencent gentle ping |
Signed-off-by: stevenkuang <[email protected]>
Politely asking, can this pull request be merged now? @CISC |
@stevenkuang-tencent Yes, but the chat template gives me pause, please follow up once model is released if there are any problems. |
Is this for upcoming models or old ones? |
It is for upcoming models. Those models will come soon. |
that's fantastic news, thanks! |
* support hunyuan_v1_dense Signed-off-by: stevenkuang <[email protected]> * update hunyuan_moe to hunyuan_v1_moe Signed-off-by: stevenkuang <[email protected]> * fix rope alpha assert and bos token Signed-off-by: stevenkuang <[email protected]> * add blank line Signed-off-by: stevenkuang <[email protected]> * Revert "update hunyuan_moe to hunyuan_v1_moe" This reverts commit aa973ca. * use hunyuan_dense instead of hunyuan_v1_dense Signed-off-by: stevenkuang <[email protected]> * fix hunyuan_moe chat template Signed-off-by: stevenkuang <[email protected]> * remove leftover code Signed-off-by: stevenkuang <[email protected]> * update hunyuan dense chat template Signed-off-by: stevenkuang <[email protected]> * fix hunyuan dense vocab and chat template Signed-off-by: stevenkuang <[email protected]> --------- Signed-off-by: stevenkuang <[email protected]>
Just wanted to chime in, tested IQ4NL quants and the output is completely incoherent. |
Same issue here, tried it with the different flags but it still doesn't work:
Example output:
|
My 3 attempts were:
|
The chat-template has been updated before the model is open sourced, and we are updating it synchronously |
@stevenkuang-tencent thank you @pwilkin I put this together and this seems to work for now, although it's not an official solution: Save as hunyuan4b.jinja:
|
What's in the "..." part? The current contents? |
I think so, when I remove it (with thinking enabled) it starts talking in Chinese again. |
Nope, on Hunyuan 7B still garbage. Tried the fixed prompt from their tokenizer config, but still doesn't work. |
I guess it might have something to do with this: |
I think 7b uses a different tokenizer. |
Yes, but it's been incorrectly uploaded from what I've seen. |
Update: