Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new dynamic way to compile and use Metal kernels. On
master
we had to pre-compile all kernels during the backend initialization. Now, we can dynamically compile the needed kernels on the fly during inference.This change unlocks the possibility to compile significantly more optimized kernels using the specific shapes of the current computation. This is achieved through the MTLFunctionConstant mechanism. Using this, we can now unroll loops significantly better and improve the overall performance.
The new kernel loading mechanism is currently applied to all Flash Attention (FA) kernels. In follow up PRs, we will continuously move all the remaining kernels and utilize function constants to improve the performance.
A secondary additional change is improved vector kernels for
Q8_0
.The impact from these changes is significantly improved performance across the board. The bigger the context, the bigger the speed up.
TODO before merge
Next PRs