-
Notifications
You must be signed in to change notification settings - Fork 13.2k
SYCL/SET: Implement and document full support for SET operator #16006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SYCL/SET: Implement and document full support for SET operator #16006
Conversation
1332bcf
to
e654008
Compare
Hi, I’ve completed the implementation of the SET operator with SYCL support. |
@ggerganov @ggerganov/ggml-maintainers |
See #16032 (review) |
@ggerganov @ggerganov/ggml-maintainers |
@NeoZhangJianyu Could you please confirm if this approach is correct, or if you’d prefer me to restructure it differently? |
@ggerganov @ggml-org/ggml-maintainers @NeoZhangJianyu Hi! I would really appreciate it if you could review my code and guide me on the next steps. |
I refactored the SET operator implementation:
@NeoZhangJianyu – please review this change from the SYCL side |
@GittyBurstein Please stop spamming - this is not going to make things faster. |
This PR adds full SYCL support for the
SET
operator in llama.cpp, ensures test coverage on f32/i32 tensors, and updates documentation to show ✅ for SYCL indocs/ops.md
.🔍 Summary of Work
Documentation updates
docs/ops/SYCL.csv
entries forSET
.support=1
anderror_message="yes"
.docs/ops.md
→ nowSET
shows ✅ under SYCL.Operator implementation (element_wise.cpp)
ggml_sycl_op_set
:dst = src0
(fast memcpy where possible).src1
ontodst
with correctoffset
,nb1
,nb2
,nb3
.f32
andi32
.SYCL backend support (ggml-sycl.cpp)
GGML_OP_SET
forGGML_TYPE_I32
inggml_backend_sycl_device_supports_op
.Testing
🛠️ Key Fixes and Lessons
offset
and strides (nb*
) was crucial.📂 Helpful Commands (Developer Reference)