Skip to content

ggml : fix dependencies for ggml_set_rows #16318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2025
Merged

ggml : fix dependencies for ggml_set_rows #16318

merged 1 commit into from
Sep 29, 2025

Conversation

ggerganov
Copy link
Member

cont #14274
ref #16063 (comment)

The result of ggml_set_rows requires to have a dependency on the destination tensor a that we actually modify.

@ggerganov ggerganov requested a review from slaren as a code owner September 28, 2025 19:09
@slaren
Copy link
Member

slaren commented Sep 28, 2025

Maybe the view_src of the tensor should also be considered a dependency, that would also solve the problem.

@github-actions github-actions bot added the ggml changes relating to the ggml tensor library for machine learning label Sep 28, 2025
@ggerganov ggerganov merged commit a4a0aa5 into master Sep 29, 2025
64 of 67 checks passed
@ggerganov ggerganov deleted the gg/fix-set-rows-deps branch September 29, 2025 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaren slaren slaren approved these changes

Assignees
No one assigned
Labels
ggml changes relating to the ggml tensor library for machine learning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggerganov @slaren