Skip to content

Conversation

@Galunid
Copy link
Contributor

@Galunid Galunid commented Oct 24, 2025

Currently when output filename is not specified, script generates file called mmproj-model-dir without any extension, in a parent directory.

This PR changes the way default filename is handled. With this change generated file will look like this model-dir/model-dir-ftype-mmproj.gguf.

Note this uses -mmproj suffix, instead of mmproj- prefix. I opted to follow the established convention.

Example:
Current: Qwen3VL-2B-Instruct/Qwen3VL-2b-Instruct-F16-mmproj.gguf
Previous: mmproj-Qwen3VL-2B-Instruct, note unspecified filetype, wrong directory and missing extension

@Galunid Galunid requested a review from CISC as a code owner October 24, 2025 18:57
@github-actions github-actions bot added the python python script changes label Oct 24, 2025
@ngxson
Copy link
Collaborator

ngxson commented Oct 24, 2025

Note this uses -mmproj suffix, instead of mmproj- prefix. I opted to follow the established convention.

I would keep the mmproj- prefix as it prevent users from downloading the wrong file, especially when long file names can be truncated when display on web / on local file browser

@Galunid
Copy link
Contributor Author

Galunid commented Oct 25, 2025

Sure, that makes sense. I updated this in my latest commit.

Co-authored-by: Sigbjørn Skjæret <[email protected]>
@CISC CISC merged commit 5d195f1 into ggml-org:master Oct 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python python script changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants