convert: Handle mmproj model output filename properly #16760
Merged
+11
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when output filename is not specified, script generates file called
mmproj-model-dirwithout any extension, in a parent directory.This PR changes the way default filename is handled. With this change generated file will look like this
model-dir/model-dir-ftype-mmproj.gguf.Note this uses
-mmprojsuffix, instead ofmmproj-prefix. I opted to follow the established convention.Example:
Current:
Qwen3VL-2B-Instruct/Qwen3VL-2b-Instruct-F16-mmproj.ggufPrevious:
mmproj-Qwen3VL-2B-Instruct, note unspecified filetype, wrong directory and missing extension