musa: remove Clang builtins mapping #9421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xiaodong Ye <[email protected]>
slaren
approved these changes
Sep 11, 2024
|
BTW, the Ollama build (after switching to the PR branch) passed as well.
diff --git a/.gitmodules b/.gitmodules
index b92f645d..d94ad752 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -1,4 +1,5 @@
[submodule "llama.cpp"]
path = llm/llama.cpp
- url = https://github.com/ggerganov/llama.cpp.git
+ url = https://github.com/makllama/llama.cpp.git
+ branch = remove_clang_builtins_mapping
shallow = true
\ No newline at end of file
diff --git a/llm/llama.cpp b/llm/llama.cpp
index 8962422b..2963165c 160000
--- a/llm/llama.cpp
+++ b/llm/llama.cpp
@@ -1 +1 @@
-Subproject commit 8962422b1c6f9b8b15f5aeaea42600bcc2d44177
+Subproject commit 2963165ced11bc8059a49b3c63f76de9d0a2378d |
dsx1986
pushed a commit
to dsx1986/llama.cpp
that referenced
this pull request
Oct 29, 2024
Signed-off-by: Xiaodong Ye <[email protected]>
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 15, 2024
Signed-off-by: Xiaodong Ye <[email protected]>
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 18, 2024
Signed-off-by: Xiaodong Ye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follow-up PR removes the Clang builtins mapping from PR #8383. MUSA compiler (mcc) now supports
__vsubss4,__vsub4,__vcmpeq4,__vcmpne4and etc.Testing done:
make GGML_MUSA=1-> passed