Upgrade to openssl-1-1-1 #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ggreer,
Hello,
This is my attempt at upgrading your library to comply with (at least) openssl-1-1-1d (because that's the current version I have here).
We're facing problems only in ssh.c and sshcrypto.c, the problem is the access to ''bignumbers'' contained in *RSA structure is not public anymore, we need to use the new API.
*RSA->key->e and *RSA->key->n are not accessible, we must use RSA_get0_key(), see https://wiki.openssl.org/index.php/OpenSSL_1.1.0_Changes. This is what I did in ssh.c
In ssh.c->connect() an RSA context is created, we need to use the new API (BN_new() is not available anymore),
good infos here https://stackoverflow.com/questions/16437475/openssl-bn-ctx-usage